openstack
/
python-cinderclient
Code Issues Proposed changes

Add test coverage for shell snapshot-create w/ metadata 

This path is not currently unit tested.

Change-Id: If38c6352f5e1f0a50e4a0d29fbdd5263ccba3b29
This commit is contained in:
Eric Harney 2022-11-07 14:44:51 -05:00
parent 9df653571d
commit dec8d4a9ee
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
cinderclient/tests/unit/v3/test_shell.py
View File

@ -970,6 +970,15 @@ class ShellTest(utils.TestCase):
}
}
SNAP_BODY_3_66_W_METADATA = {
'snapshot': {
'volume_id': '123456',
'name': None,
'description': None,
'metadata': {'a': 'b'}
}
}
@ddt.data(True, 'true', 'on', '1')
@mock.patch('cinderclient.utils.find_resource')
def test_snapshot_create_3_66_with_force_true(self, f_val, mock_find_vol):
@ -1037,6 +1046,15 @@ class ShellTest(utils.TestCase):
self.assert_called_anytime('POST', '/snapshots',
body=pre_3_66_request_body)
@mock.patch('cinderclient.utils.find_resource')
def test_snapshot_create_w_metadata(self, mock_find_vol):
mock_find_vol.return_value = volumes.Volume(
self, {'id': '123456'}, loaded=True)
self.run_command('--os-volume-api-version 3.66 '
'snapshot-create 123456 --metadata a=b')
self.assert_called_anytime('POST', '/snapshots',
body=self.SNAP_BODY_3_66_W_METADATA)
def test_snapshot_manageable_list(self):
self.run_command('--os-volume-api-version 3.8 '
'snapshot-manageable-list fakehost')