From 3eb61e6ffd2353ebf70740c2d27fd2b82ef8806c Mon Sep 17 00:00:00 2001
From: Ruby Loo <ruby.loo@intel.com>
Date: Tue, 14 Nov 2017 13:39:44 -0500
Subject: [PATCH] zuul: centralize 'irrelevant-files' list

This cleans up the zuul job definitions.

It moves the 'irrelevant-files' lists from project.yaml to
legacy-ironicclient-jobs.yaml

For irrelevant files for ironicclient-tempest-dsvm-src, it:
- adds more irrelevant files
- removes requirements.txt from the list of irrelevant files since
  we want the tests run if this file changes
- changes it to inherit from legacy-dsvm-base instead of
  legacy-ironic-dsvm-base, to remove one level of inheritance,
  which makes it simpler to see the definition

The jobs in projects.yaml are sorted in in alphabetical order.

Change-Id: I5a927592754b64a1ef64e52658b774a26947c516
---
 zuul.d/legacy-ironicclient-jobs.yaml | 32 ++++++++++++++++++++++++----
 zuul.d/project.yaml                  | 28 ++++--------------------
 2 files changed, 32 insertions(+), 28 deletions(-)

diff --git a/zuul.d/legacy-ironicclient-jobs.yaml b/zuul.d/legacy-ironicclient-jobs.yaml
index 0d9cc2f9c..2e489fcb9 100644
--- a/zuul.d/legacy-ironicclient-jobs.yaml
+++ b/zuul.d/legacy-ironicclient-jobs.yaml
@@ -1,17 +1,41 @@
 - job:
     name: ironicclient-dsvm-functional
     parent: legacy-dsvm-base
-    run: playbooks/legacy/ironicclient-dsvm-functional/run.yaml
-    post-run: playbooks/legacy/ironicclient-dsvm-functional/post.yaml
-    timeout: 4800
+    irrelevant-files:
+      - ^.*\.rst$
+      - ^doc/.*$
+      - ^releasenotes/.*$
     required-projects:
       - openstack-infra/devstack-gate
       - openstack/ironic
       - openstack/python-ironicclient
+    run: playbooks/legacy/ironicclient-dsvm-functional/run.yaml
+    post-run: playbooks/legacy/ironicclient-dsvm-functional/post.yaml
+    timeout: 4800
 
 - job:
     name: ironicclient-tempest-dsvm-src
-    parent: legacy-ironic-dsvm-base
+    # NOTE: We do not use 'legacy-ironic-dsvm-base' as it is simpler and
+    # less confusing to define it all here and use 'legacy-dsvm-base'.
+    parent: legacy-dsvm-base
+    irrelevant-files:
+      - ^test-requirements.txt$
+      - ^.*\.rst$
+      - ^doc/.*$
+      - ^ironicclient/tests/.*$
+      - ^releasenotes/.*$
+      - ^setup.cfg$
+      - ^tools/.*$
+      - ^tox.ini$
+    required-projects:
+      - openstack-infra/devstack-gate
+      - openstack/ironic
+      - openstack/ironic-lib
+      - openstack/ironic-python-agent
+      - openstack/pyghmi
+      - openstack/python-ironicclient
+      - openstack/tempest
+      - openstack/virtualbmc
     run: playbooks/legacy/ironicclient-tempest-dsvm-src/run.yaml
     post-run: playbooks/legacy/ironicclient-tempest-dsvm-src/post.yaml
     timeout: 10800
diff --git a/zuul.d/project.yaml b/zuul.d/project.yaml
index 3ad01da5f..4a2f71a62 100644
--- a/zuul.d/project.yaml
+++ b/zuul.d/project.yaml
@@ -2,29 +2,9 @@
     name: openstack/python-ironicclient
     check:
       jobs:
-        - ironicclient-tempest-dsvm-src:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^doc/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
-        - ironicclient-dsvm-functional:
-            irrelevant-files:
-              - ^.*\.rst$
-              - ^doc/.*$
-              - ^releasenotes/.*$
+        - ironicclient-dsvm-functional
+        - ironicclient-tempest-dsvm-src
     gate:
       jobs:
-        - ironicclient-tempest-dsvm-src:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^doc/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
-        - ironicclient-dsvm-functional:
-            irrelevant-files:
-              - ^.*\.rst$
-              - ^doc/.*$
-              - ^releasenotes/.*$
+        - ironicclient-dsvm-functional
+        - ironicclient-tempest-dsvm-src