openstack
/
python-ironicclient
Code Issues Proposed changes

Change confusing test class names 

These names contain 'NoMox', which is confusing when none of our tests
use mox. These were added in the commit that adds Keystone v3 API
support, and the difference between them is that they test Keystone v2
versus Keystone v3 APIs. Name them as such.

Change-Id: I72c300c546e04917bd57be327efd51e93c1d1f09
This commit is contained in:
Jim Rollenhagen 2018-03-01 11:48:53 +00:00
parent c44f6b2290
commit 25bf1a4ed9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironicclient/tests/unit/test_shell.py
View File

@ -407,9 +407,9 @@ class TestCase(testtools.TestCase):
request_mocker.get(BASE_URL, json=ks_fixture.DiscoveryList(BASE_URL))
class ShellTestNoMox(TestCase):
class ShellTestKeystoneV2(TestCase):
def setUp(self):
super(ShellTestNoMox, self).setUp()
super(ShellTestKeystoneV2, self).setUp()
self.set_fake_env(FAKE_ENV_KEYSTONE_V2)
def shell(self, argstr):
@ -471,7 +471,7 @@ class ShellTestNoMox(TestCase):
self.assertRegex(event_list_text, r)
class ShellTestNoMoxV3(ShellTestNoMox):
class ShellTestKeystoneV3(ShellTestKeystoneV2):
def _set_fake_env(self):
self.set_fake_env(FAKE_ENV_KEYSTONE_V3)