openstack
/
python-monascaclient
Code Issues Proposed changes

Remove unused TimingSession class 

TimingSession is removed and replaced by keystone session (see [1]).
This patch remove it from monasca client.

[1] https://review.openstack.org/#/c/579139/

Change-Id: I4bfcef96bcb9c8fd14e2c57f318630aa508710ca
Story: #2002978
Task: #22987
This commit is contained in:
ricolin 2018-07-16 15:38:12 +08:00
parent f0be78d01f
commit a8b6bb06b4
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
monascaclient/client.py
View File

@ -19,7 +19,6 @@ import warnings
from keystoneauth1 import identity
from keystoneauth1 import session as k_session
from osc_lib import session as o_session
from monascaclient.osc import migration
from monascaclient import version
@ -53,15 +52,14 @@ def _session(kwargs):
:type kwargs: dict
:returns: session object
:rtype union(keystoneauth1.session.Session, osc_lib.session.TimingSession)
:rtype keystoneauth1.session.Session
"""
if 'session' in kwargs:
LOG.debug('Reusing session')
sess = kwargs.get('session')
expected_cls = (k_session.Session, o_session.TimingSession)
if not isinstance(sess, expected_cls):
msg = ('session should be an instance of [%s, %s]' % expected_cls)
if not isinstance(sess, k_session.Session):
msg = ('session should be an instance of %s' % k_session.Session)
LOG.error(msg)
raise RuntimeError(msg)
else: