openstack
/
python-novaclient
Code Issues Proposed changes

trivial: Remove 'u' prefix from string 

It looks like nova is using 'repr()' in some validation error logging.
On Python 2.7, this would result in unicode strings (which most web apps
use) being output as "u'foo'", while in Python 3 these would just be
"'foo'". Since nova only supports Python 3 now, we only have to support
the Python 3 string formatting variant in our tests too.

Change-Id: I546c06a3251e86f39e2e7db48e04ec382c8da854
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This commit is contained in:
Stephen Finucane 2020-02-21 09:43:13 +00:00
parent eb98178ea8
commit 0f7d723c46
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
novaclient/tests/functional/v2/test_servers.py
View File

@ -130,7 +130,7 @@ class TestServersDescription(base.ClientTestBase):
output = self.nova("update %s --description '%s'" % (server.id, descr),
fail_ok=True, merge_stderr=True)
self.assertIn("ERROR (BadRequest): Invalid input for field/attribute"
" description. Value: %s. u\'%s\' is too long (HTTP 400)"
" description. Value: %s. '%s' is too long (HTTP 400)"
% (descr, descr), output)