openstack
/
python-novaclient
Code Issues Proposed changes

Add unit tests for client logger 

Change I53caceb08667eb12e27016731868e8015dd10e34 fixed a bug where we
weren't using our novaclient logger default when a logger was not
passed to the Client constructor.

This adds unit tests to assert the fixed behavior and protect against
regression.

Related-Bug: #1921388

Change-Id: I9f622c01a6b1abe328a60de6d3e438e68872dd80
This commit is contained in:
melanie witt 2021-04-10 02:49:37 +00:00
parent d4399d3d36
commit 21edd11ba9
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
novaclient/tests/unit/test_client.py
View File

@ -124,3 +124,15 @@ class ClientsUtilsTest(utils.TestCase):
self.assertNotEqual(original_kwargs, actual_kwargs)
self.assertEqual({}, actual_kwargs)
self.assertTrue(mock_warnings.warn.called)
class ClientTest(utils.TestCase):
def test_logger(self):
client = novaclient.client.Client('2.1', logger=mock.sentinel.logger)
self.assertEqual(mock.sentinel.logger, client.logger)
self.assertEqual(mock.sentinel.logger, client.client.logger)
client = novaclient.client.Client('2.1')
self.assertEqual('novaclient.v2.client', client.logger.name)
self.assertIsNotNone(client.client.logger)
self.assertEqual('novaclient.v2.client', client.client.logger.name)