From 465d3834719b1e26734af490451ab497519e642f Mon Sep 17 00:00:00 2001 From: henriquetruta Date: Wed, 18 Jun 2014 15:30:24 -0300 Subject: [PATCH] Fixing flavor access __repr__ method The Flavor Access __repr__ method was crashing because it was using a non-existing attribute called "name". On this fix, this method will now return the following: Closes-bug: #1331602 Change-Id: Ia2c24312e59e6c0aba1009766a15d390dc2721b1 --- novaclient/tests/v1_1/test_flavor_access.py | 12 ++++++++++++ novaclient/v1_1/flavor_access.py | 3 ++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/novaclient/tests/v1_1/test_flavor_access.py b/novaclient/tests/v1_1/test_flavor_access.py index ec937d01c..b85f838ee 100644 --- a/novaclient/tests/v1_1/test_flavor_access.py +++ b/novaclient/tests/v1_1/test_flavor_access.py @@ -56,3 +56,15 @@ class FlavorAccessTest(utils.TestCase): cs.assert_called('POST', '/flavors/2/action', body) [self.assertIsInstance(a, flavor_access.FlavorAccess) for a in r] + + def test_repr_flavor_access(self): + flavor = cs.flavors.get(2) + tenant = 'proj3' + r = cs.flavor_access.add_tenant_access(flavor, tenant) + + def get_expected(flavor_access): + return ("" % + (flavor_access.flavor_id, flavor_access.tenant_id)) + + for a in r: + self.assertEqual(get_expected(a), repr(a)) diff --git a/novaclient/v1_1/flavor_access.py b/novaclient/v1_1/flavor_access.py index 29c1f84f5..3b4ce43e6 100644 --- a/novaclient/v1_1/flavor_access.py +++ b/novaclient/v1_1/flavor_access.py @@ -21,7 +21,8 @@ from novaclient.openstack.common.gettextutils import _ class FlavorAccess(base.Resource): def __repr__(self): - return "" % self.name + return ("" % + (self.flavor_id, self.tenant_id)) class FlavorAccessManager(base.ManagerWithFind):