From 7be7d883428a0d956a6751ae786495fa5cb2a155 Mon Sep 17 00:00:00 2001 From: liyingjun Date: Fri, 13 Jun 2014 10:44:46 +0800 Subject: [PATCH] Fixes wrong value description for volume-detach MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The description of the argument is not proper, the argument is indeed "ID of the volume". “Attachment ID" is the internal term of nova/cinder. So change description 'Attachment ID of the volume.' to 'ID of the volume to detach.' Change-Id: I262d72f6f676e260a58d45b750dbd60fc7c3dcf5 Closes-bug: 1321073 --- novaclient/v1_1/shell.py | 4 ++-- novaclient/v3/shell.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/novaclient/v1_1/shell.py b/novaclient/v1_1/shell.py index 77ad1986e..d8260cc89 100644 --- a/novaclient/v1_1/shell.py +++ b/novaclient/v1_1/shell.py @@ -1787,11 +1787,11 @@ def do_volume_update(cs, args): help=_('Name or ID of server.')) @utils.arg('attachment_id', metavar='', - help=_('Attachment ID of the volume.')) + help=_('ID of the volume to detach.')) def do_volume_detach(cs, args): """Detach a volume from a server.""" cs.volumes.delete_server_volume(_find_server(cs, args.server).id, - args.attachment_id) + args.attachment_id) @utils.service_type('volume') diff --git a/novaclient/v3/shell.py b/novaclient/v3/shell.py index 35177122e..8e8f575e7 100644 --- a/novaclient/v3/shell.py +++ b/novaclient/v3/shell.py @@ -1463,11 +1463,11 @@ def do_volume_update(cs, args): help='Name or ID of server.') @utils.arg('attachment_id', metavar='', - help='Attachment ID of the volume.') + help='ID of the volume to detach.') def do_volume_detach(cs, args): """Detach a volume from a server.""" cs.volumes.delete_server_volume(_find_server(cs, args.server).id, - args.attachment_id) + args.attachment_id) @utils.arg('server', metavar='', help='Name or ID of server.')