openstack
/
python-novaclient
Code Issues Proposed changes

pass id to ServerGroupsManager in ServerGroup.delete() 

ServerGroup object delete currently fails because the manager object
requires the server group id and is instead passed the server group
object itself (copy-paste error). This patch changes it to pass the
id.

Change-Id: Ic6a4a38157f52343fbb3e75a02d1f7c6bef28d99
Closes-Bug: #1400494
This commit is contained in:
melanie witt 2014-12-10 20:41:16 +00:00
parent e13df65e35
commit 85e15fe885
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
novaclient/tests/v1_1/test_server_groups.py
View File

@ -51,3 +51,9 @@ class ServerGroupsTest(utils.FixturedTestCase):
id = '2cbd51f4-fafe-4cdb-801b-cf913a6f288b'
self.cs.server_groups.delete(id)
self.assert_called('DELETE', '/os-server-groups/%s' % id)
def test_delete_server_group_object(self):
id = '2cbd51f4-fafe-4cdb-801b-cf913a6f288b'
server_group = self.cs.server_groups.get(id)
server_group.delete()
self.assert_called('DELETE', '/os-server-groups/%s' % id)

2
novaclient/v1_1/server_groups.py
View File

@ -30,7 +30,7 @@ class ServerGroup(base.Resource):
return '<ServerGroup: %s>' % self.id
def delete(self):
self.manager.delete(self)
self.manager.delete(self.id)
class ServerGroupsManager(base.ManagerWithFind):