openstack
/
python-novaclient
Code Issues Proposed changes

Deprecate connection_pool variable 

This is the last variable which is redundant in case of SessionClient.
After this patch we will be able to use SessionClient in 100% usecases.

Change-Id: I102ba25eee7434cb66ea6efbf9ec4ab310d0957a
This commit is contained in:
Andrey Kurilin 2016-12-08 17:46:14 +02:00
parent 2163e6661a
commit b4bd07e5a7
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
novaclient/client.py
View File

@ -686,7 +686,6 @@ def _construct_http_client(api_version=None,
auth_url=None,
cacert=None,
cert=None,
connection_pool=False,
endpoint_override=None,
endpoint_type='publicURL',
http_log_debug=False,
@ -751,7 +750,6 @@ def _construct_http_client(api_version=None,
os_cache=os_cache,
http_log_debug=http_log_debug,
cacert=cacert,
connection_pool=connection_pool,
api_version=api_version,
logger=logger)
@ -911,6 +909,7 @@ def Client(version, username=None, password=None, project_id=None,
_check_arguments(kwargs, "Ocata", "tenant_id", right_name="project_id")
_check_arguments(kwargs, "Ocata", "proxy_tenant_id")
_check_arguments(kwargs, "Ocata", "proxy_token")
_check_arguments(kwargs, "Ocata", "connection_pool")
api_version, client_class = _get_client_class_and_version(version)
kwargs.pop("direct_use", None)

2
novaclient/v2/client.py
View File

@ -75,7 +75,6 @@ class Client(object):
auth_url=None,
cacert=None,
cert=None,
connection_pool=False,
direct_use=True,
endpoint_override=None,
endpoint_type='publicURL',
@ -236,7 +235,6 @@ class Client(object):
auth_url=auth_url,
cacert=cacert,
cert=cert,
connection_pool=connection_pool,
endpoint_override=endpoint_override,
endpoint_type=endpoint_type,
http_log_debug=http_log_debug,

3
releasenotes/notes/deprecate-connection-pool-arg-cef35346d5ebf40c.yaml Normal file
View File

@ -0,0 +1,3 @@
---
deprecations:
- The **connection_pool** variable is deprecated now and will be ignored.