openstack
/
python-tripleoclient
Code Issues Proposed changes

Use predictable name for generated hiera overrides 

Ditch NamedTemporaryFile where it is not really needed.
Similarly to a static 'tripleoclient-hosts-portmaps.yaml',
use 'tripleo-hieradata-override.yaml' for the hieradata
generated file.

Change-Id: I437b8b552b4e6debfd9559977b1d001697106235
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
This commit is contained in:
Bogdan Dobrelya 2018-05-04 16:38:40 +02:00
parent d432a97eec
commit 84ad50289d
1 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tripleoclient/v1/tripleo_deploy.py
View File

@ -687,19 +687,17 @@ class Deploy(command.Command):
# {parameter_defaults: {UndercloudExtraConfig: ... }}
if ('UndercloudExtraConfig' not in hiera_data.get('parameter_defaults',
{})):
with tempfile.NamedTemporaryFile(dir=self.tht_render,
prefix='hieradata-override',
suffix='.yaml',
delete=False) as override:
self.log.info('Converting hiera overrides for t-h-t from '
'legacy format into a tempfile %s' %
override.name)
yaml.safe_dump(
{'parameter_defaults': {
'UndercloudExtraConfig': hiera_data}},
override,
default_flow_style=False)
target = override.name
hiera_override_file = os.path.join(
self.tht_render, 'tripleo-hieradata-override.yaml')
self.log.info('Converting hiera overrides for t-h-t from '
'legacy format into a file %s' %
hiera_override_file)
yaml.safe_dump(
{'parameter_defaults': {
'UndercloudExtraConfig': hiera_data}},
hiera_override_file,
default_flow_style=False)
target = hiera_override_file
return target
def _standalone_deploy(self, parsed_args):