openstack
/
python-tripleoclient
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 16643 <16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 4b6738133e5e1e83c018dd2e98e4de138b8b285f
This commit is contained in:
Gerrit User 16643 2024-01-02 17:20:57 +00:00 committed by Gerrit Code Review
parent 2572f14f09
commit 89d87bae3b
1 changed files with 63 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
646a9c2187567835c8d5f453f0e6c867fe70dfc1
View File

@ -16,6 +16,69 @@
"message": "recheck",
"revId": "646a9c2187567835c8d5f453f0e6c867fe70dfc1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "47cbe6f7_043c8684",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 16643
},
"writtenOn": "2024-01-02T17:20:57Z",
"side": 1,
"message": "Thank you for adding this validation Manoj; a couple of minor comments inline",
"revId": "646a9c2187567835c8d5f453f0e6c867fe70dfc1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "44630647_e74de6bd",
"filename": "tripleoclient/utils.py",
"patchSetId": 3
},
"lineNbr": 1155,
"author": {
"id": 16643
},
"writtenOn": "2024-01-02T17:20:57Z",
"side": 1,
"message": "now changed to \"ManilaCephFSFileSystemName\"",
"range": {
"startLine": 1155,
"startChar": 13,
"endLine": 1155,
"endChar": 39
},
"revId": "646a9c2187567835c8d5f453f0e6c867fe70dfc1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d371ac5a_1729f7c4",
"filename": "tripleoclient/utils.py",
"patchSetId": 3
},
"lineNbr": 1161,
"author": {
"id": 16643
},
"writtenOn": "2024-01-02T17:20:57Z",
"side": 1,
"message": "could probably use the parameter name (\"ManilaCephFSFileSystemName\") instead?",
"range": {
"startLine": 1161,
"startChar": 51,
"endLine": 1161,
"endChar": 72
},
"revId": "646a9c2187567835c8d5f453f0e6c867fe70dfc1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}