openstack
/
python-tripleoclient
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(1 comment)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 34598 \u003c34598@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34598\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 18002 \u003c18002@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34598\u003e replied on the change"}
This commit is contained in:
Gerrit User 34598 2024-01-05 10:17:08 +00:00 committed by Gerrit Code Review
parent e940ecf435
commit b2b2bca830
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ecac88c02e9141ffc51a99bf44a0efbb77164aaf
View File

@ -33,6 +33,24 @@
"message": "If this line were the following wouldn\u0027t that be sufficient?\n\n if cephfs_filesystem_name !\u003d \"cephfs\":",
"revId": "ecac88c02e9141ffc51a99bf44a0efbb77164aaf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c34b8b85_20bb361c",
"filename": "tripleoclient/utils.py",
"patchSetId": 4
},
"lineNbr": 1156,
"author": {
"id": 34598
},
"writtenOn": "2024-01-05T10:17:08Z",
"side": 1,
"message": "nope.\nwhen i use the suggested line and if the parameter \u0027ManilaCephFSFileSystemName\u0027 is not passed via env file, cephfs_filesystem_name becomes \u0027None\u0027 and the deployment fails with exception below which is not correct.\n\n\"tripleoclient.exceptions.InvalidConfiguration: ManilaCephFSFileSystemName should not be configured for internal ceph cluster\"",
"parentUuid": "0353b618_071f2eb7",
"revId": "ecac88c02e9141ffc51a99bf44a0efbb77164aaf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}