From 5757f3a1f6aaffd2ad2dfb2748b1bc4755fc15c9 Mon Sep 17 00:00:00 2001 From: Nguyen Hung Phuong Date: Wed, 21 Feb 2018 16:32:34 +0700 Subject: [PATCH] Clean imports in code In some part in the code we import objects. In the Openstack style guidelines they recommend to import only modules. [1]: "Do not import objects, only modules". [1] https://docs.openstack.org/hacking/0.10.3/ Change-Id: I8dd5396ab604013639a0b626ce3ecd3e3fad12e8 --- troveclient/v1/shell.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/troveclient/v1/shell.py b/troveclient/v1/shell.py index c7035ea3..c0275b99 100644 --- a/troveclient/v1/shell.py +++ b/troveclient/v1/shell.py @@ -49,7 +49,7 @@ except ImportError: from troveclient import exceptions from troveclient import utils -from troveclient.v1.modules import Module +from troveclient.v1 import modules def _poll_for_status(poll_fn, obj_id, action, final_ok_states, @@ -1780,13 +1780,13 @@ def do_metadata_delete(cs, args): @utils.arg('--datastore', metavar='', help=_("Name or ID of datastore to list modules for. Use '%s' " "to list modules that apply to all datastores.") - % Module.ALL_KEYWORD) + % modules.Module.ALL_KEYWORD) @utils.service_type('database') def do_module_list(cs, args): """Lists the modules available.""" datastore = None if args.datastore: - if args.datastore.lower() == Module.ALL_KEYWORD: + if args.datastore.lower() == modules.Module.ALL_KEYWORD: datastore = args.datastore.lower() else: datastore = _find_datastore(cs, args.datastore)