Merge "fixed several pep8 issues"
This commit is contained in:
commit
9844f4dcdc
|
@ -251,7 +251,7 @@ class Resource(object):
|
|||
|
||||
def __getattr__(self, k):
|
||||
if k not in self.__dict__:
|
||||
#NOTE(bcwaldon): disallow lazy-loading if already loaded once
|
||||
# NOTE(bcwaldon): disallow lazy-loading if already loaded once
|
||||
if not self.is_loaded():
|
||||
self.get()
|
||||
return self.__getattr__(k)
|
||||
|
|
|
@ -54,7 +54,7 @@ class CommonTest(testtools.TestCase):
|
|||
status = [400, 422, 500]
|
||||
for s in status:
|
||||
resp = mock.Mock()
|
||||
#compat still uses status
|
||||
# compat still uses status
|
||||
resp.status = s
|
||||
self.assertRaises(Exception,
|
||||
common.check_for_exceptions, resp, "body")
|
||||
|
|
|
@ -19,7 +19,7 @@
|
|||
Exception definitions
|
||||
"""
|
||||
|
||||
#flake8: noqa
|
||||
# flake8: noqa
|
||||
# alias exceptions from apiclient for users of this module
|
||||
from troveclient.openstack.common.apiclient.exceptions import *
|
||||
|
||||
|
|
|
@ -61,7 +61,7 @@ class TroveClientArgumentParser(argparse.ArgumentParser):
|
|||
exits.
|
||||
"""
|
||||
self.print_usage(sys.stderr)
|
||||
#FIXME(lzyeval): if changes occur in argparse.ArgParser._check_value
|
||||
# FIXME(lzyeval): if changes occur in argparse.ArgParser._check_value
|
||||
choose_from = ' (choose from'
|
||||
progparts = self.prog.partition(' ')
|
||||
self.exit(2, "error: %(errmsg)s\nTry '%(mainp)s help %(subp)s'"
|
||||
|
@ -389,7 +389,7 @@ class OpenStackTroveShell(object):
|
|||
service_type = DEFAULT_TROVE_SERVICE_TYPE
|
||||
service_type = utils.get_service_type(args.func) or service_type
|
||||
|
||||
#FIXME(usrleon): Here should be restrict for project id same as
|
||||
# FIXME(usrleon): Here should be restrict for project id same as
|
||||
# for os_username or os_password but for compatibility it is not.
|
||||
|
||||
if not utils.isunauthenticated(args.func):
|
||||
|
@ -452,7 +452,7 @@ class OpenStackTroveShell(object):
|
|||
"Change its value via either --os-database-api-version "
|
||||
"or env[OS_DATABASE_API_VERSION]")
|
||||
% (options.os_database_api_version, endpoint_api_version))
|
||||
#raise exc.InvalidAPIVersion(msg)
|
||||
# raise exc.InvalidAPIVersion(msg)
|
||||
raise exc.UnsupportedVersion(msg)
|
||||
|
||||
# Override printing to json output
|
||||
|
|
|
@ -455,8 +455,8 @@ class ResourceTest(testtools.TestCase):
|
|||
robj._add_details(info_)
|
||||
self.assertEqual(info_["test_attr"], robj.__getattr__("test_attr"))
|
||||
|
||||
#TODO(dmakogon): looks like causing infinite recursive calls
|
||||
#robj.__getattr__("test_non_exist_attr")
|
||||
# TODO(dmakogon): looks like causing infinite recursive calls
|
||||
# robj.__getattr__("test_non_exist_attr")
|
||||
|
||||
def test___repr__(self):
|
||||
robj = self.get_mock_resource_obj()
|
||||
|
|
|
@ -67,14 +67,14 @@ class Client(object):
|
|||
config_parameters = configurations.ConfigurationParameters(self)
|
||||
self.configuration_parameters = config_parameters
|
||||
|
||||
#self.hosts = Hosts(self)
|
||||
#self.quota = Quotas(self)
|
||||
#self.storage = StorageInfo(self)
|
||||
#self.management = Management(self)
|
||||
#self.mgmt_flavor = MgmtFlavors(self)
|
||||
#self.accounts = Accounts(self)
|
||||
#self.diagnostics = DiagnosticsInterrogator(self)
|
||||
#self.hwinfo = HwInfoInterrogator(self)
|
||||
# self.hosts = Hosts(self)
|
||||
# self.quota = Quotas(self)
|
||||
# self.storage = StorageInfo(self)
|
||||
# self.management = Management(self)
|
||||
# self.mgmt_flavor = MgmtFlavors(self)
|
||||
# self.accounts = Accounts(self)
|
||||
# self.diagnostics = DiagnosticsInterrogator(self)
|
||||
# self.hwinfo = HwInfoInterrogator(self)
|
||||
|
||||
# Add in any extensions...
|
||||
if extensions:
|
||||
|
|
|
@ -129,7 +129,7 @@ class ConfigurationParameters(base.ManagerWithFind):
|
|||
def get_parameter(self, datastore, version, key):
|
||||
"""Get a list of valid parameters that can be changed."""
|
||||
return self._get("/datastores/%s/versions/%s/parameters/%s" %
|
||||
(datastore, version, key))
|
||||
(datastore, version, key))
|
||||
|
||||
def parameters_by_version(self, version):
|
||||
"""Get a list of valid parameters that can be changed."""
|
||||
|
@ -139,7 +139,7 @@ class ConfigurationParameters(base.ManagerWithFind):
|
|||
def get_parameter_by_version(self, version, key):
|
||||
"""Get a list of valid parameters that can be changed."""
|
||||
return self._get("/datastores/versions/%s/parameters/%s" %
|
||||
(version, key))
|
||||
(version, key))
|
||||
|
||||
# Appease the abc gods
|
||||
def list(self):
|
||||
|
|
Loading…
Reference in New Issue