From dbc444db9070a7b7a02def22f5c6c5f31a64d21f Mon Sep 17 00:00:00 2001 From: Shuquan Huang Date: Thu, 17 Dec 2015 22:02:34 +0800 Subject: [PATCH] Replace assertEqual(None, *) with assertIsNone in tests Replace assertEqual(None, *) with assertIsNone in tests to have more clear messages in case of failure. Change-Id: Idd271edb45dafed10aad255267ff0b9722cabe2d Closes-bug: #1280522 --- troveclient/tests/test_base.py | 2 +- troveclient/tests/test_configurations.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/troveclient/tests/test_base.py b/troveclient/tests/test_base.py index 594336ee..4bfaefe1 100644 --- a/troveclient/tests/test_base.py +++ b/troveclient/tests/test_base.py @@ -301,7 +301,7 @@ class MangerPaginationTests(ManagerTest): self.manager.api.client.get.assert_called_with(self.next_url) self.assertEqual('p3', resp.items[0].foo) self.assertEqual('p4', resp.items[1].foo) - self.assertEqual(None, resp.next) + self.assertIsNone(resp.next) self.assertEqual([], resp.links) self.assertTrue(isinstance(resp, common.Paginated)) diff --git a/troveclient/tests/test_configurations.py b/troveclient/tests/test_configurations.py index c8e13f20..5850d7e2 100644 --- a/troveclient/tests/test_configurations.py +++ b/troveclient/tests/test_configurations.py @@ -248,4 +248,4 @@ class MgmtConfigurationParametersTest(testtools.TestCase): self.config_params.delete('id', 'param_id') self.assertEqual('/mgmt/datastores/versions/id/parameters/param_id', self._url) - self.assertEqual(None, self._body) + self.assertIsNone(self._body)