openstack
/
sahara-dashboard
Code Issues Proposed changes

Improve pulling configs for node groups 

Now in file sahara_dashboard/content/data_processing/
nodegroup_templates/workflows/create.py in 445 and 448
lines we get general and service parameters with two
api calls to sahara.
It will be more optimize if we will create only one
api call to sahara.

Change-Id: I5305143d0430d4cd25ba98ce3145a0ab545210c7
Partial-bug: 1430112
This commit is contained in:
Mikhail Lelyakin 2016-09-06 17:32:43 +03:00
parent 177ce51f46
commit 039f02408f
2 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sahara_dashboard/content/data_processing/clusters/nodegroup_templates/workflows/create.py
View File

@ -442,12 +442,9 @@ class ConfigureNodegroupTemplate(workflow_helpers.ServiceParametersWorkflow,
plugin, hadoop_version = (
workflow_helpers.get_plugin_and_hadoop_version(request))
general_parameters = hlps.get_general_node_group_configs(
plugin,
hadoop_version)
service_parameters = hlps.get_targeted_node_group_configs(
plugin,
hadoop_version)
general_parameters, service_parameters = \
hlps.get_general_and_service_nodegroups_parameters(plugin,
hadoop_version)
if saharaclient.base.is_service_enabled(request, 'share'):
ConfigureNodegroupTemplate._register_step(self,

18
sahara_dashboard/content/data_processing/utils/helpers.py
View File

@ -67,18 +67,20 @@ class Helpers(object):
return self._extract_parameters(plugin.configs, 'node', 'general')
def get_targeted_node_group_configs(self, plugin_name, hadoop_version):
plugin = saharaclient.plugin_get_version_details(self.request,
plugin_name,
hadoop_version)
def get_general_and_service_nodegroups_parameters(self, plugin_name,
hadoop_version):
plugin = saharaclient.plugin_get_version_details(
self.request, plugin_name, hadoop_version)
parameters = {}
general_parameters = self._extract_parameters(
plugin.configs, 'node', 'general')
service_parameters = {}
for service in plugin.node_processes.keys():
parameters[service] = self._extract_parameters(plugin.configs,
'node', service)
service_parameters[service] = self._extract_parameters(
plugin.configs, 'node', service)
return parameters
return general_parameters, service_parameters
def get_targeted_cluster_configs(self, plugin_name, hadoop_version):
plugin = saharaclient.plugin_get_version_details(self.request,