openstack
/
salt-formula-ceilometer
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(2 comments)

Looks promising :-)
Please fix inline comments.

Patch-set: 1
Reviewer: Gerrit User 18092 <18092@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 18092 2016-02-16 11:31:19 +00:00 committed by Gerrit Code Review
parent 9484e3c7fc
commit c82f71a43e
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
ab30065231b74dd45509e4519853608203831121 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "dae33548_761e6864",
"filename": "ceilometer.spec",
"patchSetId": 1
},
"lineNbr": 24,
"author": {
"id": 18092
},
"writtenOn": "2016-02-16T11:31:19Z",
"side": 1,
"message": "Is it possible to install files subdirectories using some wildcard?\nThis will require fixing spec file pretty often to produce rpm package with complete files.",
"revId": "ab30065231b74dd45509e4519853608203831121",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dae33548_fb126161",
"filename": "ceilometer.spec",
"patchSetId": 1
},
"lineNbr": 58,
"author": {
"id": 18092
},
"writtenOn": "2016-02-16T11:31:19Z",
"side": 1,
"message": "It\u0027s not needed to restart salt-master after formula installation.",
"revId": "ab30065231b74dd45509e4519853608203831121",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}