openstack
/
shade
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(1 comment)

One suggested improvement to catch the initial failure if there are cascading failures.

Patch-set: 1
Label: Code-Review=-1
This commit is contained in:
Gerrit User 3099 2015-01-12 21:32:50 +00:00 committed by Gerrit Code Review
parent 43b8b126db
commit 56ebe515af
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
75c385ac4eef885e831a70435d8d3f3ace3d80f5 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "3a961159_5d86aebb",
"filename": "shade/__init__.py",
"patchSetId": 1
},
"lineNbr": 708,
"author": {
"id": 3099
},
"writtenOn": "2015-01-12T21:32:50Z",
"side": 1,
"message": "I\u0027d make this the first line of the exception handling, in case the other ironic_client calls in this section should happen to fail. I won\u0027t mention how those are not being caught.... oops, too late.",
"revId": "75c385ac4eef885e831a70435d8d3f3ace3d80f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}