Update patch set 2

Patch Set 2: Code-Review-1

(5 comments)

Patch-set: 2
Label: Code-Review=-1

8801f7bbe399c0fde92524322db3ed9ffb439263

@@ -0,0 +1,89 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3a961159_938050c0",
+        "filename": "shade/__init__.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 448,
+      "author": {
+        "id": 1
+      },
+      "writtenOn": "2015-01-08T23:34:31Z",
+      "side": 1,
+      "message": "If we\u0027re doing our own integrity checks, maybe we can switch to sha-256?",
+      "revId": "8801f7bbe399c0fde92524322db3ed9ffb439263",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3a961159_b3838cc9",
+        "filename": "shade/__init__.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 456,
+      "author": {
+        "id": 1
+      },
+      "writtenOn": "2015-01-08T23:34:31Z",
+      "side": 1,
+      "message": "We don\u0027t return anything usefur to the caller...",
+      "revId": "8801f7bbe399c0fde92524322db3ed9ffb439263",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3a961159_d36d7833",
+        "filename": "shade/__init__.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 466,
+      "author": {
+        "id": 1
+      },
+      "writtenOn": "2015-01-08T23:34:31Z",
+      "side": 1,
+      "message": "This returns an ID, which is great.  I guess this does a PUT and gets the image id in the response?  So the upload is complete when this is done?  Is there further server-side processing that needs to be done?  Is it included in that call, or does it happen afterwords async?",
+      "revId": "8801f7bbe399c0fde92524322db3ed9ffb439263",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3a961159_f368b422",
+        "filename": "shade/__init__.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 491,
+      "author": {
+        "id": 1
+      },
+      "writtenOn": "2015-01-08T23:34:31Z",
+      "side": 1,
+      "message": "Wait, what is this task engine in glanceclient doing?  What\u0027s happening in the background?  I guess this is the same question as above... is it doing a put and then reading the response?  Or is it waiting for further server processing after the put?\n\nNothing else works like this, right?  So for consistency, shouldn\u0027t this library just always be synchronous?  That\u0027s the way I would want to use it in nodepool, which generally expects to do things synchronously in one thread per provider, except for when we expect something to be really long (like uploading an image), in which case we do that in another thread.\n\nSo in short, what I really want out of this function is an HTTP put call.  If glanceclient isn\u0027t willing to do that, then I think we should emulate it by waiting for its task to complete.  However, there\u0027s a further complication with this timeout mechanism -- what if this method times out, but glanceclient eventually finishes in the background.  Then we\u0027ve lied to the user.  Is there a way to abort a task?\n\nSo in short, this should always be synchronous (or everything should be asynchronous).  And it should either return an id, or raise an exception (and in that case, we should be certain that nothing was done).",
+      "revId": "8801f7bbe399c0fde92524322db3ed9ffb439263",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3a961159_137460fc",
+        "filename": "shade/__init__.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 501,
+      "author": {
+        "id": 1
+      },
+      "writtenOn": "2015-01-08T23:34:31Z",
+      "side": 1,
+      "message": "Returning a glanceclient task seems like a layer violation.",
+      "revId": "8801f7bbe399c0fde92524322db3ed9ffb439263",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}