openstack
/
stackviz
Code Issues Proposed changes

Correct potential edge cast in binaryMinIndex and binaryMaxIndex when a search value is out of bounds.

This commit is contained in:
Tim Buckley 2015-08-18 13:54:33 -06:00
parent f15bcf0545
commit f39db38cea
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
stackviz/static/js/timeline.js
View File

@ -40,7 +40,9 @@ var binaryMinIndex = function(min, array, func) {
}
}
if (func(array[left]) <= min) {
if (left >= array.length) {
return array.length - 1;
} else if (func(array[left]) <= min) {
return left;
} else {
return left - 1;
@ -65,7 +67,9 @@ var binaryMaxIndex = function(max, array, func) {
}
}
if (func(array[right]) <= max) {
if (right < 0) {
return 0;
} else if (func(array[right]) <= max) {
return right + 1; // exclusive index
} else {
return right;