From 21a8c43dab102ed754e43f6633b0f5ee09587630 Mon Sep 17 00:00:00 2001
From: Rahul U Nair <rahulunair@gmail.com>
Date: Mon, 9 May 2016 15:13:11 -0500
Subject: [PATCH] Fixed a few nitpicks in the code base

Replaced `None` with `{}` in http/models.py
Removed urllib disable warnings.
Changed `sql_strings` to `bof_strings`
Removed `as` in import statement in runner.py
Removed non needed new line in arguments.py

Change-Id: I6f5285b446bd44054360ae7bfc6c1893c1341f03
---
 syntribos/arguments.py                  |  1 -
 syntribos/clients/http/models.py        | 10 +++++-----
 syntribos/runner.py                     | 11 ++---------
 syntribos/tests/fuzz/base_fuzz.py       |  1 +
 syntribos/tests/fuzz/buffer_overflow.py |  2 +-
 5 files changed, 9 insertions(+), 16 deletions(-)

diff --git a/syntribos/arguments.py b/syntribos/arguments.py
index 62981480..ceaffe91 100644
--- a/syntribos/arguments.py
+++ b/syntribos/arguments.py
@@ -58,7 +58,6 @@ class InputType(object):
 
 
 class SyntribosCLI(argparse.ArgumentParser):
-
     """Class for parsing Syntribos command-line arguments."""
 
     def __init__(self, *args, **kwargs):
diff --git a/syntribos/clients/http/models.py b/syntribos/clients/http/models.py
index 785b8997..5e3b5c12 100644
--- a/syntribos/clients/http/models.py
+++ b/syntribos/clients/http/models.py
@@ -134,11 +134,11 @@ class RequestObject(object):
     """An object that holds information about an HTTP request."""
 
     def __init__(
-        self, method, url, action_field=None, headers=None, params=None,
-            data=None):
+        self, method, url, action_field={}, headers={}, params={},
+            data={}):
         self.method = method
         self.url = url
-        self.headers = headers or {}
-        self.params = params or {}
-        self.data = data
         self.action_field = action_field
+        self.headers = headers
+        self.params = params
+        self.data = data
diff --git a/syntribos/runner.py b/syntribos/runner.py
index 2605af08..ceb4b22a 100644
--- a/syntribos/runner.py
+++ b/syntribos/runner.py
@@ -17,14 +17,8 @@ import sys
 import time
 import unittest
 
-import requests
-
-from cafe.common.reporting.cclogging import(
-    init_root_log_handler as init_root_log_handler
-)
-from cafe.configurator.managers import(
-    TestEnvManager as TestEnvManager
-)
+from cafe.common.reporting.cclogging import init_root_log_handler
+from cafe.configurator.managers import TestEnvManager
 import cafe.drivers.base
 
 import syntribos.arguments
@@ -112,7 +106,6 @@ class Runner(object):
     @classmethod
     def run(cls):
         global result
-        requests.packages.urllib3.disable_warnings()
         try:
             cls.print_symbol()
             usage = """
diff --git a/syntribos/tests/fuzz/base_fuzz.py b/syntribos/tests/fuzz/base_fuzz.py
index 2f9a02e0..73ac8a0b 100644
--- a/syntribos/tests/fuzz/base_fuzz.py
+++ b/syntribos/tests/fuzz/base_fuzz.py
@@ -134,6 +134,7 @@ class BaseFuzzTestCase(base.BaseTestCase):
         self.test_default_issues() in order to test for the Issues
         defined here
         """
+
         if self.resp.status_code >= 500:
             self.register_issue(
                 Issue(test="500_errors",
diff --git a/syntribos/tests/fuzz/buffer_overflow.py b/syntribos/tests/fuzz/buffer_overflow.py
index d80d7e33..2564fa44 100644
--- a/syntribos/tests/fuzz/buffer_overflow.py
+++ b/syntribos/tests/fuzz/buffer_overflow.py
@@ -42,7 +42,7 @@ class BufferOverflowBody(base_fuzz.BaseFuzzTestCase):
         failed_strings = self.data_driven_failure_cases()
         if failed_strings:
             self.register_issue(
-                Issue(test="sql_strings",
+                Issue(test="bof_strings",
                       severity="Medium",
                       confidence="Low",
                       text=("The string(s): \'{0}\', known to be commonly "