Make validation_resources a stable interface

Move the module to tempest.lib, add unit tests, release notes and
update imports.

Change-Id: I76b3b8e9a83bd83a6b5742b6d2ceb84642f653ad

doc/source/library.rst

@@ -69,3 +69,4 @@ Current Library APIs
    library/auth
    library/clients
    library/credential_providers
+   library/validation_resources

doc/source/library/validation_resources.rst

@@ -0,0 +1,11 @@
+.. _validation_resources:
+
+Validation Resources
+====================
+
+-------------------------------
+The validation_resources module
+-------------------------------
+
+.. automodule:: tempest.lib.common.validation_resources
+   :members:

releasenotes/notes/add-validation-resources-to-lib-dc2600c4324ca4d7.yaml

@@ -0,0 +1,7 @@
+---
+features:
+  - |
+    Add the `validation_resources` module to tempest.lib. The module provides
+    a set of helpers that can be used to provision and cleanup all the
+    resources required to perform ping / ssh tests against a virtual machine:
+    a keypair, a security group with targeted rules and a floating IP.

tempest/test.py

@@ -26,10 +26,10 @@ import testtools
 from tempest import clients
 from tempest.common import credentials_factory as credentials
 from tempest.common import utils
-import tempest.common.validation_resources as vr
 from tempest import config
 from tempest.lib.common import cred_client
 from tempest.lib.common import fixed_network
+from tempest.lib.common import validation_resources as vr
 from tempest.lib import decorators
 from tempest.lib import exceptions as lib_exc
 

tempest/tests/lib/common/test_validation_resources.py

@@ -15,7 +15,7 @@ import fixtures
 import mock
 import testtools
 
-from tempest.common import validation_resources as vr
+from tempest.lib.common import validation_resources as vr
 from tempest.lib import exceptions as lib_exc
 from tempest.lib.services import clients
 from tempest.tests import base

tempest/tests/test_test.py

@@ -20,8 +20,8 @@ from oslo_config import cfg
 import testtools
 
 from tempest import clients
-from tempest.common import validation_resources as vr
 from tempest import config
+from tempest.lib.common import validation_resources as vr
 from tempest.lib import exceptions as lib_exc
 from tempest import test
 from tempest.tests import base
@@ -48,7 +48,7 @@ class LoggingTestResult(testtools.TestResult):
 
 class TestValidationResources(base.TestCase):
 
-    validation_resources_module = 'tempest.common.validation_resources'
+    validation_resources_module = 'tempest.lib.common.validation_resources'
 
     def setUp(self):
         super(TestValidationResources, self).setUp()