Update patch set 3

Abandoned

TrieplO project is retiring now, for details, please see https://review.opendev.org/c/openstack/governance/+/905145  or reach out to OpenStack TC.

Patch-set: 3
Status: abandoned
Tag: autogenerated:gerrit:abandon
This commit is contained in:
Gerrit User 8556 2024-02-26 19:52:33 +00:00 committed by Gerrit Code Review
parent b99013c8c7
commit e11f14fbaa
1 changed files with 87 additions and 10 deletions

View File

@ -1,6 +1,7 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "3fa7e38b_4b5407c7",
"filename": "roles/build-containers/tasks/main.yaml",
@ -20,10 +21,10 @@
"endChar": 21
},
"revId": "80a0939e3cbaa229815160d2b9fe611dc5b08947",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3fa7e38b_eb95a995",
"filename": "roles/build-containers/tasks/main.yaml",
@ -44,10 +45,10 @@
"endChar": 21
},
"revId": "80a0939e3cbaa229815160d2b9fe611dc5b08947",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3fa7e38b_0b62853e",
"filename": "roles/build-containers/tasks/main.yaml",
@ -68,10 +69,10 @@
"endChar": 21
},
"revId": "80a0939e3cbaa229815160d2b9fe611dc5b08947",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3fa7e38b_eb4b7325",
"filename": "roles/build-containers/templates/build.sh.j2",
@ -91,10 +92,10 @@
"endChar": 16
},
"revId": "80a0939e3cbaa229815160d2b9fe611dc5b08947",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3fa7e38b_8b64354f",
"filename": "roles/build-containers/vars/main.yaml",
@ -108,8 +109,84 @@
"side": 1,
"message": "really this one is x86_64 excludes (or at least its only even applied to x86_64 thus far)\n\nand altarch_excludes is for ppc (or per discussion other archs potentially too).\n\nMy point is to answer folco\u0027s comment, not sure we can merge these two things.\n\nIt depends if we need to also keep what is in exclude_containers for ppc..\n\ni.e. for ppc builds do we need to skip all the exclude_containers stuff , as well as https://review.opendev.org/#/c/699024/3/roles/build-containers/tasks/main.yaml that stuff\n\nIf so yeah we could re-use these vars but in the set_fact for ppc you\u0027d have to extend what\u0027s already in exclude_containers and not just override it",
"revId": "80a0939e3cbaa229815160d2b9fe611dc5b08947",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
],
"submitRequirementResults": [
{
"submitRequirement": {
"name": "Code-Review",
"description": {
"value": "Code reviewed by core reviewer"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "80a0939e3cbaa229815160d2b9fe611dc5b08947",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Verified",
"description": {
"value": "Verified in gate by CI"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":["label:Verified=MIN"],"failingAtoms":["label:Verified=MAX"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "80a0939e3cbaa229815160d2b9fe611dc5b08947",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Workflow",
"description": {
"value": "Approved for gate by core reviewer"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Workflow=MAX"],"failingAtoms":["label:Workflow=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "80a0939e3cbaa229815160d2b9fe611dc5b08947",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
}
]
}