Bind mount /var/lib/iscsi in containers using iSCSI

Services that create iSCSI connections need to share the connection info
that gets created in /var/lib/iscsi. It's especially important that the
host has knowledge of *all* connections so that it can disconnect them
whenever the host shuts down or reboots.

Note: Minor changes were included in the backport to stable/rocky.
- The ":z" propagation suffix added to the volume mounts in stein were
  omitted.
- In stein the glance-api service templates were moved to the unified
  deployment/glance-api directory, so the rocky changes are made in the
  original docker/services directory.

Closes-Bug: #1810338
Change-Id: I803ed2ba9ff52f9a02c550a28d21cc9102568c8e
(cherry picked from commit 243cb34615)
(cherry picked from commit f37b5e0622)

docker/services/cinder-common.yaml

@@ -145,6 +145,7 @@ outputs:
           - /run/:/run/
           - /sys:/sys
           - /var/lib/cinder:/var/lib/cinder
+          - /var/lib/iscsi:/var/lib/iscsi
           - /var/log/containers/cinder:/var/log/cinder
 
   cinder_volume_environment:
@@ -170,6 +171,7 @@ outputs:
           - /sys:/sys
           - /lib/modules:/lib/modules:ro
           - /var/lib/cinder:/var/lib/cinder
+          - /var/lib/iscsi:/var/lib/iscsi
           - /var/log/containers/cinder:/var/log/cinder
 
   cinder_backup_environment:

docker/services/glance-api.yaml

@@ -196,6 +196,7 @@ outputs:
                     - cinder_backend_enabled
                     - - /dev:/dev
                       - /etc/iscsi:/etc/iscsi
+                      - /var/lib/iscsi:/var/lib/iscsi
                     - []
             environment:
               - KOLLA_BOOTSTRAP=True

docker/services/iscsid.yaml

@@ -102,6 +102,7 @@ outputs:
                   - /sys:/sys
                   - /lib/modules:/lib/modules:ro
                   - /etc/iscsi:/var/lib/kolla/config_files/src-iscsid:ro
+                  - /var/lib/iscsi:/var/lib/iscsi
             environment:
               - KOLLA_CONFIG_STRATEGY=COPY_ALWAYS
       host_prep_tasks:

docker/services/multipathd.yaml

@@ -84,6 +84,7 @@ outputs:
                   - /sys:/sys
                   - /lib/modules:/lib/modules:ro
                   - /var/lib/cinder:/var/lib/cinder
+                  - /var/lib/iscsi:/var/lib/iscsi
             environment:
               - KOLLA_CONFIG_STRATEGY=COPY_ALWAYS
       host_prep_tasks:

docker/services/nova-compute.yaml

@@ -225,6 +225,7 @@ outputs:
                   - /dev:/dev
                   - /lib/modules:/lib/modules:ro
                   - /run:/run
+                  - /var/lib/iscsi:/var/lib/iscsi
                   - /var/lib/nova:/var/lib/nova:shared
                   - /var/lib/libvirt:/var/lib/libvirt
                   - /sys/class/net:/sys/class/net

docker/services/nova-ironic.yaml

@@ -140,6 +140,7 @@ outputs:
                   - /etc/iscsi:/var/lib/kolla/config_files/src-iscsid:ro
                   - /run:/run
                   - /dev:/dev
+                  - /var/lib/iscsi:/var/lib/iscsi
                   - /var/lib/nova/:/var/lib/nova:shared
                   - /var/log/containers/nova:/var/log/nova
             environment: