openstack
/
trove
Code Issues Proposed changes

Remove unused variables 

o trove/backup/models.py:SWIFT_CONTAINER = CONF.backup_swift_container

  This variable was added in the following commit.

    commit ce208d6cab
    Author: ruiyuan-shen <ruiyuan.shen@hp.com>
    Date:   Mon Mar 18 14:07:37 2013 -0700

        Add snapshot ORM to reddwarf

  But there is no evidence that was used.

o trove/dns/rsdns/driver.py:DNS_HOSTNAME = CONF.dns_hostname

  This variable was added in the following commit.

    commit 0c34c75dc4
    Author: Sudarshan Acharya <sudarshan.acharya@rackspace.com>
    Date:   Fri May 18 15:49:12 2012 -0500

        DNS Support for Instance IP.

  But there is no evidence that was used.

o trove/instance/models.py:SERVER_INVALID_ACTION_STATUSES
   = ["BUILD", "REBOOT", "REBUILD", "RESIZE"]

  This variable was removed in the following commit.

    commit 54a4ada785
    Author: Ed Cranford <ed.cranford@rackspace.com>
    Date:   Thu Jul 12 15:01:01 2012 -0500

        Delete can now delete errored instances.

o trove/instance/models.py:VALID_ACTION_STATUSES = ["ACTIVE"]

  This variable was removed in the following commit.

    commit 9ccef6fea4
    Author: Tim Simpson <tim.simpson@rackspace.com>
    Date:   Wed Jun 27 11:12:28 2012 -0500

        Allowing resizes to be performed when MySQL is down.

Closes-Bug: #1286990
Change-Id: I79f5bb124f2702317d8d337c969c9ff8ea69a769
This commit is contained in:
KIYOHIRO ADACHI 2014-02-28 14:43:31 +09:00
parent 8f200b7371
commit 506438b92f
3 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
trove/backup/models.py
View File

@ -28,7 +28,6 @@ from trove.quota.quota import run_with_quotas
CONF = cfg.CONF
LOG = logging.getLogger(__name__)
SWIFT_CONTAINER = CONF.backup_swift_container
class BackupState(object):

1
trove/dns/rsdns/driver.py
View File

@ -33,7 +33,6 @@ from trove.dns.driver import DnsEntry
CONF = cfg.CONF
DNS_HOSTNAME = CONF.dns_hostname
DNS_ACCOUNT_ID = CONF.dns_account_id
DNS_AUTH_URL = CONF.dns_auth_url
DNS_DOMAIN_NAME = CONF.dns_domain_name

7
trove/instance/models.py
View File

@ -106,13 +106,6 @@ def load_simple_instance_server_status(context, db_info):
db_info.addresses = {}
# If the compute server is in any of these states we can't perform any
# actions (delete, resize, etc).
SERVER_INVALID_ACTION_STATUSES = ["BUILD", "REBOOT", "REBUILD", "RESIZE"]
# Statuses in which an instance can have an action performed.
VALID_ACTION_STATUSES = ["ACTIVE"]
# Invalid states to contact the agent
AGENT_INVALID_STATUSES = ["BUILD", "REBOOT", "RESIZE"]