openstack
/
ui-cookiecutter
Code Issues Proposed changes

Merge "Fix errors on eslint"

This commit is contained in:
Jenkins 2017-08-22 02:34:30 +00:00 committed by Gerrit Code Review
parent 1a60d3c425 0fda3714ea
commit e5135b5036
5 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
{{cookiecutter.repo_name}}/{{cookiecutter.module_name}}/static/dashboard/{{cookiecutter.panel_group}}/{{cookiecutter.api_module}}.service.js
View File

@ -30,14 +30,13 @@
get{{cookiecutter.panel_func}}s: get{{cookiecutter.panel_func}}s,
create{{cookiecutter.panel_func}}: create{{cookiecutter.panel_func}},
update{{cookiecutter.panel_func}}: update{{cookiecutter.panel_func}},
delete{{cookiecutter.panel_func}}: delete{{cookiecutter.panel_func}},
delete{{cookiecutter.panel_func}}: delete{{cookiecutter.panel_func}}
};
return service;
///////////////
// {{cookiecutter.panel_func}}s //
///////////////
///////////////////////////////
// {{cookiecutter.panel_func}}s
function get{{cookiecutter.panel_func}}(id) {
return apiService.get('/api/{{cookiecutter.api_module}}/{{cookiecutter.panel}}s/' + id)

5
{{cookiecutter.repo_name}}/{{cookiecutter.module_name}}/static/dashboard/{{cookiecutter.panel_group}}/{{cookiecutter.panel_group}}.module.js
View File

@ -21,12 +21,14 @@
* @description
* Dashboard module to host various {{cookiecutter.panel_group}} panels.
*/
// fixme: if ngRoute and $routeProvider are unnecessary, remove them
/* eslint-disable no-unused-vars */
angular
.module('horizon.dashboard.{{cookiecutter.panel_group}}', [
'horizon.dashboard.{{cookiecutter.panel_group}}.{{cookiecutter.panel}}s',
'ngRoute'
])
.config(config)
.config(config);
config.$inject = ['$provide', '$windowProvider', '$routeProvider'];
@ -34,4 +36,5 @@
var path = $windowProvider.$get().STATIC_URL + 'dashboard/{{cookiecutter.panel_group}}/';
$provide.constant('horizon.dashboard.{{cookiecutter.panel_group}}.basePath', path);
}
/* eslint-disable no-unused-vars */
})();

10
{{cookiecutter.repo_name}}/{{cookiecutter.module_name}}/static/dashboard/{{cookiecutter.panel_group}}/{{cookiecutter.panel}}s/details/overview.controller.js
View File

@ -19,17 +19,11 @@
.controller('horizon.dashboard.{{cookiecutter.panel_group}}.{{cookiecutter.panel}}s.OverviewController', controller);
controller.$inject = [
'$scope',
'horizon.dashboard.{{cookiecutter.panel_group}}.{{cookiecutter.panel}}s.resourceType',
'horizon.dashboard.{{cookiecutter.panel_group}}.{{cookiecutter.panel}}s.events',
'horizon.framework.conf.resource-type-registry.service'
'$scope'
];
function controller(
$scope,
resourceType,
events,
registry
$scope
) {
var ctrl = this;
ctrl.{{cookiecutter.panel}} = {};

7
{{cookiecutter.repo_name}}/{{cookiecutter.module_name}}/static/dashboard/{{cookiecutter.panel_group}}/{{cookiecutter.panel}}s/{{cookiecutter.panel}}s.module.js
View File

@ -38,6 +38,7 @@
* @ngdoc constant
* @name horizon.dashboard.{{cookiecutter.panel_group}}.{{cookiecutter.panel}}s.events
* @description A list of events used by {{cookiecutter.panel_func}}
* @returns {Object} events
*/
function events() {
return {
@ -56,11 +57,13 @@
function run(registry, service, basePath, resourceType) {
registry.getResourceType(resourceType)
.setNames(gettext('{{cookiecutter.panel_func}}'), gettext('{{cookiecutter.panel_func}}s'))
// for detail summary view on table row
// for detail summary view on table row
.setSummaryTemplateUrl(basePath + 'details/drawer.html')
// for table row items and detail summary view.
// specify items for table row items, summary view and details view
.setProperties(properties())
// get items for table
.setListFunction(service.getPromise)
// specify table columns
.tableColumns
.append({
id: 'name',

2
{{cookiecutter.repo_name}}/{{cookiecutter.module_name}}/static/dashboard/{{cookiecutter.panel_group}}/{{cookiecutter.panel}}s/{{cookiecutter.panel}}s.service.js
View File

@ -52,7 +52,7 @@
var timestamp = item.updated_at ? item.updated_at : item.created_at;
item.trackBy = item.id.concat(timestamp);
return item;
};
}
}
function urlFunction(item) {