From dd702058f87f68c378da89c970b212452b3e651d Mon Sep 17 00:00:00 2001 From: Iury Gregory Melo Ferreira Date: Fri, 17 Apr 2020 20:54:44 +0200 Subject: [PATCH] Stop configuring install_command in tox. Currently, we are overriding 'install_command' to use 'pip'. This is considered poor behavior and 'python -m pip' should be used instead: https://snarky.ca/why-you-should-use-python-m-pip/ It turns out that this is the the default value provided by tox: https://tox.readthedocs.io/en/latest/config.html#conf-install_command So we can remove the line and simply use the default value. openstack-discuss thread http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014237.html Change-Id: I2cdb74a8d3ce88c3b6d7b4f84b0aa0a990753ce5 --- tox.ini | 1 - 1 file changed, 1 deletion(-) diff --git a/tox.ini b/tox.ini index f97cdbf..c60997d 100644 --- a/tox.ini +++ b/tox.ini @@ -12,7 +12,6 @@ setenv = VIRTUAL_ENV={envdir} LANGUAGE=en_US LC_ALL=en_US.UTF-8 TESTS_DIR=./virtualbmc/tests/unit/ -install_command = pip install {opts} {packages} deps = -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} -r{toxinidir}/test-requirements.txt