openstack
/
virtualbmc
Code Issues Proposed changes

Stop configuring install_command in tox. 

Currently, we are overriding 'install_command' to use 'pip'. This is
considered poor behavior and 'python -m pip' should be used instead:

https://snarky.ca/why-you-should-use-python-m-pip/

It turns out that this is the the default value provided by tox:

https://tox.readthedocs.io/en/latest/config.html#conf-install_command

So we can remove the line and simply use the default value.

openstack-discuss thread
http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014237.html

Change-Id: I2cdb74a8d3ce88c3b6d7b4f84b0aa0a990753ce5
This commit is contained in:
Iury Gregory Melo Ferreira 2020-04-17 20:54:44 +02:00
parent 8c1fc05fee
commit dd702058f8
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tox.ini
View File

@ -12,7 +12,6 @@ setenv = VIRTUAL_ENV={envdir}
LANGUAGE=en_US
LC_ALL=en_US.UTF-8
TESTS_DIR=./virtualbmc/tests/unit/
install_command = pip install {opts} {packages}
deps =
-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
-r{toxinidir}/test-requirements.txt