Add .gitreview file

- Fix the target to pep8 instead of flake8 to get tests passing.
- Exclude H803 pep8 check.
- Correct pep8 error.

Change-Id: I90c7abafb6a23e46ff8b0210ff49e37d79730948
This commit is contained in:
Chmouel Boudjnah 2013-11-15 09:04:54 +01:00 committed by Chmouel Boudjnah
parent 4523c3ae55
commit d72c24a184
7 changed files with 9 additions and 8 deletions

4
.gitreview Normal file
View File

@ -0,0 +1,4 @@
[gerrit]
host=review.openstack.org
port=29418
project=stackforge/swiftsync.git

View File

@ -88,7 +88,7 @@ def create_swift_user(client, account_name, account_id, user_amount):
if role.name == get_config('filler', 'swift_operator_role')]
if not roleid:
logging.error('Could not find swift_operator_role %s in keystone' %
get_config('filler', 'swift_operator_role'))
get_config('filler', 'swift_operator_role'))
sys.exit(1)
roleid = roleid[0]
# Add tenant/user in swift operator role/group

View File

@ -209,7 +209,6 @@ class TestSyncer(unittest.TestCase):
"""create two empty accounts, Sync only one
"""
index = {}
test_account_name = "account_test"
# create account
self.created = filler.create_swift_account(self.o_ks_client,

View File

@ -213,7 +213,7 @@ class TestAccountSync(TestAccountBase):
"http://test.com", tenant_name, "user", "password")
tenant_id = fakes.TENANTS_LIST[tenant_name]['id']
self.assertEqual(ret[0], "%s/v1/AUTH_%s" % (fakes.STORAGE_DEST,
tenant_id))
tenant_id))
def test_get_ks_auth_orig(self):
_, kwargs = self.accounts_cls.get_ks_auth_orig()()

View File

@ -1,7 +1,6 @@
simplejson
http://tarballs.openstack.org/swift/swift-master.tar.gz#egg=swift
python-swiftclient
webob
python-dateutil
netifaces
python-keystoneclient

View File

@ -4,7 +4,6 @@ distribute>=0.6.24
mox
nose
nosehtmloutput
openstack.nose_plugin
testrepository>=0.0.13
testtools>=0.9.22
unittest2

View File

@ -1,5 +1,5 @@
[tox]
envlist = py27,flake8
envlist = py27,pep8
[testenv]
setenv = VIRTUAL_ENV={envdir}
@ -14,7 +14,7 @@ deps = -r{toxinidir}/tools/pip-requires
-r{toxinidir}/tools/test-requires
commands = python setup.py testr --testr-args="{posargs}"
[testenv:flake8]
[testenv:pep8]
sitepackages = False
commands = flake8 --show-source swsync bin setup.py tests
@ -28,6 +28,6 @@ commands = python setup.py testr --coverage
downloadcache = ~/cache/pip
[flake8]
ignore = E12,E711,E721,E712,H302,H303,H403,H404,F
ignore = E12,E711,E721,E712,H302,H303,H403,H404,H803
builtins = _
exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,plugins,tools