Update patch set 2

Browse Source

Patch Set 2:

I assume you talk about the checksum of 'last_modified' and 'name' for the diff but I'm pretty sure the consumption will be higher :( and we need two different base sets for the diff and delete_diff :(.

We can iterate over the objects of orig and dest to only  retrieve 'last_modified' and 'name' and avoid the other useless data. That way will have sets from orig and dest ready to compute the diff. Delete_diff computation can be done by cleaning the sets of the 'last_modified' entry.

But it can be nice to have a get_container_iter in the swiftclient instead of returning a list that can be really huge we only return an iterator and let the user consume it how he want. Sound a good idea for me ? If it sounds good for you to, I'll provide a patch to swiftclient.

Patch-set: 2

...

This commit is contained in:

Gerrit User 6889 2014-02-18 11:51:45 +00:00 committed by Gerrit Code Review

parent b03c08d26d

commit e8d83b354a

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available