starlingx
/
integ
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review+2 Workflow+1

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 8768 <8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 86d2911a24876c7bf5c0d8bcff11118821ed0fec
Label: Workflow=+1, 20710910d36c5d545f91cdb79810fda0ebbd13fe
Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
This commit is contained in:
Gerrit User 8768 2024-05-07 15:33:18 +00:00 committed by Gerrit Code Review
parent dac4b79820
commit 7282f56c96
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
4f9a8b85c2b87a837e6fb36103a8630df7b4ea9c
View File

@ -16,6 +16,23 @@
"message": "looks good to me",
"revId": "4f9a8b85c2b87a837e6fb36103a8630df7b4ea9c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bb321fc8_fa3028e5",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 8768
},
"writtenOn": "2024-05-07T15:33:18Z",
"side": 1,
"message": "looks reasonable, good work.\n\nShould probably consider proposing the equivalent fix upstream at https://github.com/intel/intel-device-plugins-for-kubernetes/blob/main/pkg/deviceplugin/server.go#L251 given that we will probably need to re-write this plugin to use the newer device plugin API at some point.",
"revId": "4f9a8b85c2b87a837e6fb36103a8630df7b4ea9c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}