starlingx
/
specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(2 comments)

Patch-set: 5
Reviewer: Gerrit User 8768 <8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, eebc679ba71905dbc4868fed11c4f48e413dad33
Attention: {"person_ident":"Gerrit User 36728 \u003c36728@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
This commit is contained in:
Gerrit User 8768 2024-05-03 21:36:27 +00:00 committed by Gerrit Code Review
parent 4cbf4efe9b
commit 0d35860cf3
1 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
20ba8b7d1db1dbcff20efbf67c181f5dfa68ee76 Normal file
View File

@ -0,0 +1,50 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "7c299f98_3e6035eb",
"filename": "doc/source/specs/stx-10.0/approved/starlingx-2011105-cstate-management.rst",
"patchSetId": 5
},
"lineNbr": 85,
"author": {
"id": 8768
},
"writtenOn": "2024-05-03T21:36:27Z",
"side": 1,
"message": "I think the CPU cores can either be isolated *or* be exclusively assigned to the application pods.",
"range": {
"startLine": 85,
"startChar": 4,
"endLine": 85,
"endChar": 64
},
"revId": "20ba8b7d1db1dbcff20efbf67c181f5dfa68ee76",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f7d2d349_6c737d14",
"filename": "doc/source/specs/stx-10.0/approved/starlingx-2011105-cstate-management.rst",
"patchSetId": 5
},
"lineNbr": 115,
"author": {
"id": 8768
},
"writtenOn": "2024-05-03T21:36:27Z",
"side": 1,
"message": "isn\u0027t this basically duplicating lines 80-100 ?",
"range": {
"startLine": 101,
"startChar": 0,
"endLine": 115,
"endChar": 73
},
"revId": "20ba8b7d1db1dbcff20efbf67c181f5dfa68ee76",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}