From c72df1cde87b1706f8cc68dce80fd011543b155a Mon Sep 17 00:00:00 2001 From: Robert Collins Date: Fri, 23 Feb 2018 12:28:16 +1300 Subject: [PATCH] Don't lose sync requests that get bad responses Gerrit servers under some configurations will return a result that doesn't fail in checkResponse but isn't JSON. When that happens the action being synced is discarded and lost. This has been the case for nearly 4 years as far as I can tell. Change-Id: I9f4c36cf50acefab4806e7617226c979465d384d --- gertty/sync.py | 1 + 1 file changed, 1 insertion(+) diff --git a/gertty/sync.py b/gertty/sync.py index b504ece..52eb774 100644 --- a/gertty/sync.py +++ b/gertty/sync.py @@ -1496,6 +1496,7 @@ class Sync(object): except Exception: self.log.exception("Unable to parse result %s from post to %s" % (r.text, url)) + raise return ret def put(self, path, data):