ttygroup
/
gertty
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 19119 \u003c19119@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_19119\u003e replied on the change"}
This commit is contained in:
Gerrit User 19119 2024-02-26 19:56:18 +00:00 committed by Gerrit Code Review
parent 093d49e2de
commit f16c3bbacb
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
9846bcacf302c9c7bb0c45fd2d71a7df12c80a30
View File

@ -16,6 +16,24 @@
"message": "Thanks for the patch!\n\nYour point #1 is clear -- it looks like this is fixed is urwid \u003e\u003d2.0.0.\n\nI\u0027m not sure I fully understand #2 though. Are you saying that the workaround you are removing in this patch was not quite correct, in that the focus would not follow the expected direction based on a keypress? Or something else?\n\nI want to understand that in case there\u0027s something I should focus on when testing this patch. But so far I haven\u0027t found an issue with it.",
"revId": "9846bcacf302c9c7bb0c45fd2d71a7df12c80a30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9179bbe1_a96b166b",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 19119
},
"writtenOn": "2024-02-26T19:56:18Z",
"side": 1,
"message": "\u003e Thanks for the patch!\n\u003e \n\u003e Your point #1 is clear -- it looks like this is fixed is urwid \u003e\u003d2.0.0.\n\u003e \n\u003e I\u0027m not sure I fully understand #2 though. Are you saying that the workaround you are removing in this patch was not quite correct, in that the focus would not follow the expected direction based on a keypress? Or something else?\n\u003e \n\u003e I want to understand that in case there\u0027s something I should focus on when testing this patch. But so far I haven\u0027t found an issue with it.\n\nOriginal hack was pointed on urwid issue, which technically included several behavior patterns.\nBuggy part was fixed (on the last urwid even fixed weird behavior with empty containers pack/render), non buggy part: if buttons are in multiple rows - \"rigth\" button goes only to the right column, not to the next row",
"parentUuid": "988c8892_2dfe4881",
"revId": "9846bcacf302c9c7bb0c45fd2d71a7df12c80a30",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}