Fix typo with zuul_user_home

Add unit test and assert /var/lib/zuul is the home directory.

Change-Id: I1557b12570d443a54c71ab044e5a5c9dbd6b3ba2
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

defaults/main.yaml

@@ -15,7 +15,7 @@
 # tasks/config.yaml
 zuul_user_name: zuul
 zuul_user_group: "{{ zuul_user_name }}"
-zuul_user_home: "/var/lib/${{ zuul_user_name }}"
+zuul_user_home: "/var/lib/{{ zuul_user_name }}"
 
 zuul_config_gearman_port: 4730
 zuul_config_gearman_server: localhost

tests/test.yaml

@@ -25,3 +25,13 @@
 
   roles:
     - "{{ rolename }}"
+
+  post_tasks:
+    - name: Register zuul_user_home_result
+      shell: '/usr/bin/getent passwd zuul | cut -d: -f6'
+      register: zuul_user_home_result
+
+    - name: Assert zuul_user_home is /var/lib/zuul
+      assert:
+        that:
+          - zuul_user_home_result.stdout == '/var/lib/zuul'