Update patch set 5

Patch Set 5: Code-Review-1 (2 comments) Already few remarks to work on, but I didn't finish the review yet Patch-set: 5 Label: Code-Review=-1
2016-04-12 14:32:38 +00:00 · 2016-04-12 14:32:38 +00:00 · de727c107a
parent 2073f1cf50
commit de727c107a
1 changed files with 50 additions and 0 deletions
--- a/50
+++ b/50
@ -0,0 +1,50 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "5a18252c_1b7948fd",
+        "filename": "bareon_allocator/solvers/linear_program_creator.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 179,
+      "author": {
+        "id": 15454
+      },
+      "writtenOn": "2016-04-12T14:32:38Z",
+      "side": 1,
+      "message": "remove this, there is no fourth space",
+      "range": {
+        "startLine": 179,
+        "startChar": 62,
+        "endLine": 179,
+        "endChar": 72
+      },
+      "revId": "4adeaf951c93ad056a5d452cacb737d16a58f9e3",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a18252c_0249d45f",
+        "filename": "bareon_allocator/solvers/linear_program_creator.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 243,
+      "author": {
+        "id": 15454
+      },
+      "writtenOn": "2016-04-12T14:32:38Z",
+      "side": 1,
+      "message": "it should start here from 2 as in docs http://bareon-allocator.readthedocs.org/en/latest/architecture.html#best-with-disks\n\nI suggest to add \u0027start\u0027 argument to init",
+      "range": {
+        "startLine": 243,
+        "startChar": 24,
+        "endLine": 243,
+        "endChar": 50
+      },
+      "revId": "4adeaf951c93ad056a5d452cacb737d16a58f9e3",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}