x
/
bareon-specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Reviewer: Gerrit User 10488 <10488@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 10488 2016-01-18 13:23:59 +00:00 committed by Gerrit Code Review
parent 4b88f9aae5
commit 00bed3be2e
1 changed files with 64 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
8e657399e3a6226ff78708ddaaaaf2faaa0f2d92
View File

@ -86,6 +86,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_c546f220",
"filename": "specs/pluggable-do-actions.rst",
"patchSetId": 1
},
"lineNbr": 24,
"author": {
"id": 10488
},
"writtenOn": "2016-01-18T13:23:59Z",
"side": 1,
"message": "may be change to \"we\u0027ll never build image in bootstrap loaded node\"",
"range": {
"startLine": 24,
"startChar": 15,
"endLine": 24,
"endChar": 57
},
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_c8383940",
@ -132,6 +155,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_25602e35",
"filename": "specs/pluggable-do-actions.rst",
"patchSetId": 1
},
"lineNbr": 46,
"author": {
"id": 10488
},
"writtenOn": "2016-01-18T13:23:59Z",
"side": 1,
"message": "bareon/drivers/",
"range": {
"startLine": 46,
"startChar": 9,
"endLine": 46,
"endChar": 16
},
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_a844e573",
@ -195,6 +241,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_a5dbbeec",
"filename": "specs/pluggable-do-actions.rst",
"patchSetId": 1
},
"lineNbr": 54,
"author": {
"id": 10488
},
"writtenOn": "2016-01-18T13:23:59Z",
"side": 1,
"message": "+1, Also what should I do if bareon doesn\u0027t contain necessary utils methods or I need additional objects or something else? What about additional parameters which should come from console?",
"parentUuid": "da6ed579_33a94a7c",
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_0e63b9dd",