Update patch set 1
Patch Set 1: (12 comments) Also it's not visiable here http://docs-draft.openstack.org/16/266416/1/check/gate-bareon-specs-docs/c54b3ac//doc/build/html/ Do you know why? Patch-set: 1 Label: Verified=0
This commit is contained in:
Gerrit User 15454
Gerrit Code Review
parent
7db20f63fd
commit
a9aac423ed
|
|
@ -0,0 +1,262 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_ee2f453c",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 21,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "Currently",
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_a89f0502",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 22,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "use asterisk instead of dashes everywhere",
|
||||
"range": {
|
||||
"startLine": 22,
|
||||
"startChar": 2,
|
||||
"endLine": 22,
|
||||
"endChar": 3
|
||||
},
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_289475e0",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 22,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "leave new line after each element in the list",
|
||||
"range": {
|
||||
"startLine": 22,
|
||||
"startChar": 69,
|
||||
"endLine": 22,
|
||||
"endChar": 73
|
||||
},
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_c8ea79ac",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 23,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "partitioning",
|
||||
"range": {
|
||||
"startLine": 23,
|
||||
"startChar": 66,
|
||||
"endLine": 23,
|
||||
"endChar": 77
|
||||
},
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_c8383940",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 25,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "brings",
|
||||
"range": {
|
||||
"startLine": 25,
|
||||
"startChar": 32,
|
||||
"endLine": 25,
|
||||
"endChar": 37
|
||||
},
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_f929518a",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 28,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "contributors",
|
||||
"range": {
|
||||
"startLine": 28,
|
||||
"startChar": 40,
|
||||
"endLine": 28,
|
||||
"endChar": 51
|
||||
},
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_a844e573",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 49,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "drivers",
|
||||
"range": {
|
||||
"startLine": 49,
|
||||
"startChar": 0,
|
||||
"endLine": 49,
|
||||
"endChar": 6
|
||||
},
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_f329728a",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 51,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "remove \u0027be\u0027",
|
||||
"range": {
|
||||
"startLine": 51,
|
||||
"startChar": 22,
|
||||
"endLine": 51,
|
||||
"endChar": 24
|
||||
},
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_33a94a7c",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 54,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "Are any further details will be presented in this spec? Like how drivers will be implemented?\nWhat methods will have the base class for all drivers, and what for?\n\nAFAIU there must be some kind of \u0027base-bareon\u0027 (to have the base extension class somewhere) with minimal requirements and bareon extensions in separate modules with more requirements, right?\n\nHow will problems like data intersection will be resolved? For example when we want to use cloud-init with configdrive for provisioning, we should somehow tell the driver responsible for partitioning to reserve the space for config drive.",
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_0e63b9dd",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 58,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "That is not a problem. The problem here is that current architecture is not expendable (maybe even maintainable). Pluggable extensions is one of the ways to resolve the problem. The other ways are:\n\n- just make every `do action` independent from others, but then the node we want to only provision will have to have the dependencies for e.g. partitioning also. And it won\u0027t be expendable for Users.\n- create separate project for every usecase, but the will be lots of code duplications and hard to maintain.",
|
||||
"range": {
|
||||
"startLine": 58,
|
||||
"startChar": 23,
|
||||
"endLine": 58,
|
||||
"endChar": 61
|
||||
},
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_8e5809fc",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 59,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "we could use other plugin system like \n \nhttp://pluginbase.pocoo.org/\nhttp://yapsy.sourceforge.net/",
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "da6ed579_193545d9",
|
||||
"filename": "specs/pluggable-do-actions.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 78,
|
||||
"author": {
|
||||
"id": 15454
|
||||
},
|
||||
"writtenOn": "2016-01-13T08:46:52Z",
|
||||
"side": 1,
|
||||
"message": "remove white space",
|
||||
"range": {
|
||||
"startLine": 78,
|
||||
"startChar": 7,
|
||||
"endLine": 78,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "8e657399e3a6226ff78708ddaaaaf2faaa0f2d92",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue