110 lines
4.2 KiB
Plaintext
110 lines
4.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3a57f1b5_9c67c724",
|
|
"filename": "specs/consistent-disk-identification.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 38,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2016-02-11T15:01:53Z",
|
|
"side": 1,
|
|
"message": "As far as I know all these data are provided [1], also there is an example of algorithm how we perform matching, because even disks ids can be duplicated\n\n[1] https://github.com/openstack/fuel-web/blob/bfe882b65d982b82e92bef376018dfeb7ae4c9c6/nailgun/nailgun/extensions/volume_manager/manager.py#L668-L715",
|
|
"revId": "7453426a74ff7ee3515699c71d86590a5f94e6ff",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3a57f1b5_3486e0db",
|
|
"filename": "specs/consistent-disk-identification.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 38,
|
|
"author": {
|
|
"id": 8968
|
|
},
|
|
"writtenOn": "2016-02-11T16:37:39Z",
|
|
"side": 1,
|
|
"message": "that\u0027s fuel-web, anything similar in bareon currently?",
|
|
"parentUuid": "3a57f1b5_9c67c724",
|
|
"revId": "7453426a74ff7ee3515699c71d86590a5f94e6ff",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dae33548_d077779d",
|
|
"filename": "specs/consistent-disk-identification.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 38,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2016-02-16T12:25:59Z",
|
|
"side": 1,
|
|
"message": "As far as I know bareon has the same extra field and the logic of disk search was adjusted [0], [1].\n\n[0] https://github.com/openstack/fuel-agent/blob/master/fuel_agent/drivers/nailgun.py#L58-L69\n[1] https://github.com/openstack/fuel-agent/blob/master/fuel_agent/drivers/nailgun.py#L222-L228",
|
|
"parentUuid": "3a57f1b5_3486e0db",
|
|
"revId": "7453426a74ff7ee3515699c71d86590a5f94e6ff",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dae33548_88be2963",
|
|
"filename": "specs/consistent-disk-identification.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 38,
|
|
"author": {
|
|
"id": 8968
|
|
},
|
|
"writtenOn": "2016-02-17T10:42:23Z",
|
|
"side": 1,
|
|
"message": "Ok, thanks.\nAnyways this identification is enclosed in Ironic data driver, should not intersect with existing one. Once other features migrate to main driver (simple or nailgun) Cray can migrate to bareon implementation of consistent identification.\n\nThis spec can be abandoned now I think?",
|
|
"parentUuid": "dae33548_d077779d",
|
|
"revId": "7453426a74ff7ee3515699c71d86590a5f94e6ff",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dae33548_28e98fb7",
|
|
"filename": "specs/consistent-disk-identification.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 38,
|
|
"author": {
|
|
"id": 8749
|
|
},
|
|
"writtenOn": "2016-02-18T13:23:59Z",
|
|
"side": 1,
|
|
"message": "If it works for you, we can abandon it I think.",
|
|
"parentUuid": "dae33548_88be2963",
|
|
"revId": "7453426a74ff7ee3515699c71d86590a5f94e6ff",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dae33548_7f9e9863",
|
|
"filename": "specs/consistent-disk-identification.rst",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 39,
|
|
"author": {
|
|
"id": 3009
|
|
},
|
|
"writtenOn": "2016-02-18T20:03:10Z",
|
|
"side": 1,
|
|
"message": "In fact you need to be able to identify disk not only through power cycles but also through various kernel versions. And these values scsi and by-path links can change. In fuel-agent/bareon we first try to use wwn or serial number to identify disks. So I think you can use the same. I agree this spec should be abandoned or at least it should suggest better way.",
|
|
"revId": "7453426a74ff7ee3515699c71d86590a5f94e6ff",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |