x
/
cloudbase-init
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(4 comments)

Patch-set: 4
This commit is contained in:
Gerrit User 36901 2024-05-15 09:27:51 +00:00 committed by Gerrit Code Review
parent 44b49b06dc
commit 1005ccd150
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
4b31421987982d5a950cb6c92da1fde2c1773cf9
View File

@ -17,6 +17,24 @@
"revId": "4b31421987982d5a950cb6c92da1fde2c1773cf9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f3ed7f36_a34213ca",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 11,
"author": {
"id": 36901
},
"writtenOn": "2024-05-15T09:27:51Z",
"side": 1,
"message": "Added the support to bonds and vlans except bridges.",
"parentUuid": "6ea58638_187cbb8b",
"revId": "4b31421987982d5a950cb6c92da1fde2c1773cf9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -51,6 +69,24 @@
"revId": "4b31421987982d5a950cb6c92da1fde2c1773cf9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fb607216_3beb566f",
"filename": "cloudbaseinit/metadata/services/vmwareguestinfoservice.py",
"patchSetId": 3
},
"lineNbr": 185,
"author": {
"id": 36901
},
"writtenOn": "2024-05-15T09:27:51Z",
"side": 1,
"message": "New class NoCloudNetworkConfigV2Parser is created and new test cases for this class are also added.",
"parentUuid": "2c3ad926_246a1497",
"revId": "4b31421987982d5a950cb6c92da1fde2c1773cf9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -68,6 +104,24 @@
"revId": "4b31421987982d5a950cb6c92da1fde2c1773cf9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3f2cccd2_403aa691",
"filename": "cloudbaseinit/plugins/common/networkconfig.py",
"patchSetId": 3
},
"lineNbr": 146,
"author": {
"id": 36901
},
"writtenOn": "2024-05-15T09:27:51Z",
"side": 1,
"message": "Sure. Change was discarded.",
"parentUuid": "062e28ed_d3347860",
"revId": "4b31421987982d5a950cb6c92da1fde2c1773cf9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -84,6 +138,24 @@
"message": "great to see unit tests that will make sure we have almost all cases covered.",
"revId": "4b31421987982d5a950cb6c92da1fde2c1773cf9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cf0a6a6e_fba8e8f2",
"filename": "cloudbaseinit/tests/metadata/services/test_vmwareguestinfoservice.py",
"patchSetId": 3
},
"lineNbr": 293,
"author": {
"id": 36901
},
"writtenOn": "2024-05-15T09:27:51Z",
"side": 1,
"message": "I believe most cases are covered for now.",
"parentUuid": "95e577d0_2e422c13",
"revId": "4b31421987982d5a950cb6c92da1fde2c1773cf9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}