Fix calls to create_ovs_vif_port

create_ovs_vif_port has six required arguments:
* bridge
* dev
* iface_id
* mac
* instance_id
* mtu

And an optional argument - timeout.

However calls to create_ovs_vif_port only supplied five of six required
arguments and the optional argument, and mocks to the call also had the
incorrect number of arguments. Therefore the unit tests passed but any
code that actually called create_ovs_vif_port would have thrown an
error.

Change-Id: Ic165557da57cf6df1fd39309b16e0a89a02df16d
This commit is contained in:
Sean M. Collins 2016-02-24 14:03:21 -05:00
parent be8c70fe5d
commit 5e72ecd5ad
2 changed files with 2 additions and 0 deletions

View File

@ -115,6 +115,7 @@ class OvsHybridPlugin(plugin.PluginBase):
v2_name,
vif.port_profile.interface_id,
vif.address, instance_info.uuid,
self.config.network_device_mtu,
timeout=self.config.ovs_vsctl_timeout)
def unplug(self, vif, instance_info):

View File

@ -95,6 +95,7 @@ class PluginTest(testtools.TestCase):
'br0', 'qvovif-xxx-yyy', 'aaa-bbb-ccc',
'ca:fe:de:ad:be:ef',
'f0000000-0000-0000-0000-000000000001',
1500,
timeout=120)]
}
# The disable_ipv6 call needs to be added in the middle, if required