x
/
deb-oslo.vmware
Code Issues Proposed changes

Remove explicit use of asserts 

The Bandit linter flagged code using the assert function. This
removes the assert and ensures an exception is thrown with
another call.

Change-Id: I582e0985e46414f97bd15d6d763bae132de7c12a
This commit is contained in:
Eric Brown 2016-03-04 10:58:42 -08:00
parent fa93ed4972
commit 90ca36466b
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
oslo_vmware/tests/test_service.py
View File

@ -53,12 +53,12 @@ class ServiceTest(base.TestCase):
self.SudsClientMock = patcher.start()
def test_retrieve_properties_ex_fault_checker_with_empty_response(self):
try:
service.Service._retrieve_properties_ex_fault_checker(None)
assert False
except exceptions.VimFaultException as ex:
self.assertEqual([exceptions.NOT_AUTHENTICATED],
ex.fault_list)
ex = self.assertRaises(
exceptions.VimFaultException,
service.Service._retrieve_properties_ex_fault_checker,
None)
self.assertEqual([exceptions.NOT_AUTHENTICATED],
ex.fault_list)
def test_retrieve_properties_ex_fault_checker(self):
fault_list = ['FileFault', 'VimFault']
@ -72,11 +72,11 @@ class ServiceTest(base.TestCase):
response = mock.Mock()
response.objects = [obj_cont]
try:
service.Service._retrieve_properties_ex_fault_checker(response)
assert False
except exceptions.VimFaultException as ex:
self.assertEqual(fault_list, ex.fault_list)
ex = self.assertRaises(
exceptions.VimFaultException,
service.Service._retrieve_properties_ex_fault_checker,
response)
self.assertEqual(fault_list, ex.fault_list)
def test_request_handler(self):
managed_object = 'VirtualMachine'