From f5714cdaddba45079ef207a16abc3c0241841326 Mon Sep 17 00:00:00 2001 From: Gerrit User 15334 <15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Thu, 18 Jul 2019 13:22:44 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: Code-Review-1 (3 comments) I'd personally much rather see a minimal '__main__.py' file that migrate the whole thing across like this. Patch-set: 1 Reviewer: Gerrit User 15334 <15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 --- e7602b9dd182805c1e80996a676fe1069cc09b94 | 67 ++++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 e7602b9dd182805c1e80996a676fe1069cc09b94 diff --git a/e7602b9dd182805c1e80996a676fe1069cc09b94 b/e7602b9dd182805c1e80996a676fe1069cc09b94 new file mode 100644 index 0000000..77f3189 --- /dev/null +++ b/e7602b9dd182805c1e80996a676fe1069cc09b94 @@ -0,0 +1,67 @@ +{ + "comments": [ + { + "key": { + "uuid": "7faddb67_3dab4a75", + "filename": "doc8/__main__.py", + "patchSetId": 1 + }, + "lineNbr": 0, + "author": { + "id": 15334 + }, + "writtenOn": "2019-07-18T13:22:44Z", + "side": 1, + "message": "There\u0027s an awful lot of content here for a \u0027__main__\u0027 file. I\u0027ve seen these files and \u0027__init__\u0027 files kept to a minimum as people don\u0027t tend to look at them. Would it make more sense to leave this file as-is and just add a minimal \u0027__main__.py\u0027 that included everything from below that\u0027s inside a \u0027if __name__ \u003d\u003d \"__main__\"\u0027 statement?", + "revId": "e7602b9dd182805c1e80996a676fe1069cc09b94", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "7faddb67_5da646ad", + "filename": "doc8/__main__.py", + "patchSetId": 1 + }, + "lineNbr": 39, + "author": { + "id": 15334 + }, + "writtenOn": "2019-07-18T13:22:44Z", + "side": 1, + "message": "All of these will always evaluate to true to now", + "range": { + "startLine": 39, + "startChar": 0, + "endLine": 39, + "endChar": 26 + }, + "revId": "e7602b9dd182805c1e80996a676fe1069cc09b94", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "7faddb67_1d90ce49", + "filename": "tox.ini", + "patchSetId": 1 + }, + "lineNbr": 27, + "author": { + "id": 15334 + }, + "writtenOn": "2019-07-18T13:22:44Z", + "side": 1, + "message": "I think this is probably unnecessary but I\u0027ll allow it :)", + "range": { + "startLine": 26, + "startChar": 0, + "endLine": 27, + "endChar": 26 + }, + "revId": "e7602b9dd182805c1e80996a676fe1069cc09b94", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file