x
/
fixtures-git
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(3 comments)

Patch-set: 1
Label: Verified=0
This commit is contained in:
Gerrit User 1054 2019-05-22 14:56:30 +00:00 committed by Gerrit Code Review
parent 004cffff5e
commit 745af91d2f
1 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
5bb72719fce93a93cf79169436088012281280d7
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_5faeba98",
"filename": "fixtures_git/gitfixture.py",
"patchSetId": 1
},
"lineNbr": 295,
"author": {
"id": 1054
},
"writtenOn": "2019-05-22T14:56:30Z",
"side": 1,
"message": "Updated the code to use the username/password if username is set",
"parentUuid": "bfb3d3c7_6903d074",
"revId": "5bb72719fce93a93cf79169436088012281280d7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_8995e4e6",
@ -40,6 +58,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_dfc06a2d",
"filename": "fixtures_git/gitfixture.py",
"patchSetId": 1
},
"lineNbr": 315,
"author": {
"id": 1054
},
"writtenOn": "2019-05-22T14:56:30Z",
"side": 1,
"message": "Not necessarily, I believe tokens are an accepted and in which case you might want to set username to \u0027\u0027 and password to the token or vice versa and the filter will remove the unset variable (works with None or \u0027\u0027) from the list returned to ensure that auth is just the \u0027token\u0027 by itself instead of \u0027:token\u0027 or \u0027token:\u0027 as would be the case otherwise.",
"parentUuid": "bfb3d3c7_8995e4e6",
"range": {
"startLine": 315,
"startChar": 8,
"endLine": 315,
"endChar": 36
},
"revId": "5bb72719fce93a93cf79169436088012281280d7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_c96d1c99",
@ -62,6 +104,30 @@
"revId": "5bb72719fce93a93cf79169436088012281280d7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_9fa432bb",
"filename": "fixtures_git/gitfixture.py",
"patchSetId": 1
},
"lineNbr": 317,
"author": {
"id": 1054
},
"writtenOn": "2019-05-22T14:56:30Z",
"side": 1,
"message": "Removed, thanks.",
"parentUuid": "bfb3d3c7_c96d1c99",
"range": {
"startLine": 317,
"startChar": 30,
"endLine": 317,
"endChar": 37
},
"revId": "5bb72719fce93a93cf79169436088012281280d7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}