Update patch set 6

Patch Set 6:

(2 comments)

Patch-set: 6
Label: Verified=0
This commit is contained in:
Gerrit User 5557 2018-04-16 14:42:56 +00:00 committed by Gerrit Code Review
parent a0d2300585
commit 76aed64aa2
1 changed files with 50 additions and 0 deletions

View File

@ -0,0 +1,50 @@
{
"comments": [
{
"key": {
"uuid": "9f6a8fd7_18cf2f80",
"filename": "tests/base.py",
"patchSetId": 6
},
"lineNbr": 39,
"author": {
"id": 5557
},
"writtenOn": "2018-04-16T14:42:56Z",
"side": 1,
"message": "How does this check the order?",
"range": {
"startLine": 39,
"startChar": 11,
"endLine": 39,
"endChar": 55
},
"revId": "28295b49bd36af0ffff7bc500a7d83db2814414f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f6a8fd7_18d08ff7",
"filename": "tests/test_toposort.py",
"patchSetId": 6
},
"lineNbr": 76,
"author": {
"id": 5557
},
"writtenOn": "2018-04-16T14:42:56Z",
"side": 1,
"message": "The testtools matcher protocol suggests to me that the expected value is a property of the matcher object and the actual value is passed to the match() method, but you\u0027re reversing that here.\nAs a testtoosl noob I find that confusing - is it normal practice?",
"range": {
"startLine": 73,
"startChar": 8,
"endLine": 76,
"endChar": 9
},
"revId": "28295b49bd36af0ffff7bc500a7d83db2814414f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}