x
/
fuel-ccp-elasticsearch
Code Issues Proposed changes

Update patch set 8 

Patch Set 8: Code-Review-1

(5 comments)

Patch-set: 8
Label: Code-Review=-1
This commit is contained in:
Gerrit User 7710 2017-03-17 12:33:31 +00:00 committed by Gerrit Code Review
parent d1cdf3f1af
commit ba88ab85bd
1 changed files with 107 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

107
6dbc2c12b38533c8477309d8d3392b2d905de3b9 Normal file
View File

@ -0,0 +1,107 @@
{
"comments": [
{
"key": {
"uuid": "1a1ced50_6d350d45",
"filename": "docker/elasticsearch/Dockerfile.j2",
"patchSetId": 8
},
"lineNbr": 6,
"author": {
"id": 7710
},
"writtenOn": "2017-03-17T12:33:31Z",
"side": 1,
"message": "let\u0027s remove it",
"revId": "6dbc2c12b38533c8477309d8d3392b2d905de3b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a1ced50_2d1235b5",
"filename": "docker/elasticsearch/Dockerfile.j2",
"patchSetId": 8
},
"lineNbr": 11,
"author": {
"id": 7710
},
"writtenOn": "2017-03-17T12:33:31Z",
"side": 1,
"message": "please make url configurable",
"range": {
"startLine": 11,
"startChar": 9,
"endLine": 11,
"endChar": 59
},
"revId": "6dbc2c12b38533c8477309d8d3392b2d905de3b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a1ced50_0d4739bc",
"filename": "docker/elasticsearch/Dockerfile.j2",
"patchSetId": 8
},
"lineNbr": 13,
"author": {
"id": 7710
},
"writtenOn": "2017-03-17T12:33:31Z",
"side": 1,
"message": "already installed in base image",
"range": {
"startLine": 13,
"startChar": 4,
"endLine": 13,
"endChar": 71
},
"revId": "6dbc2c12b38533c8477309d8d3392b2d905de3b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a1ced50_0d1e59ba",
"filename": "docker/elasticsearch/Dockerfile.j2",
"patchSetId": 8
},
"lineNbr": 14,
"author": {
"id": 7710
},
"writtenOn": "2017-03-17T12:33:31Z",
"side": 1,
"message": "you can remove it",
"revId": "6dbc2c12b38533c8477309d8d3392b2d905de3b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a1ced50_8d1169af",
"filename": "docker/elasticsearch/Dockerfile.j2",
"patchSetId": 8
},
"lineNbr": 15,
"author": {
"id": 7710
},
"writtenOn": "2017-03-17T12:33:31Z",
"side": 1,
"message": "make url configurable",
"range": {
"startLine": 15,
"startChar": 17,
"endLine": 15,
"endChar": 62
},
"revId": "6dbc2c12b38533c8477309d8d3392b2d905de3b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}