x
/
fuel-ccp-entrypoint
Code Issues Proposed changes

Update patch set 12 

Patch Set 12: Code-Review-1

(3 comments)

Patch-set: 12
Label: Code-Review=-1
This commit is contained in:
Gerrit User 18652 2017-02-13 14:24:20 +00:00 committed by Gerrit Code Review
parent f07ae9c08b
commit a5530c4f84
1 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
8263d9303c1ea47c7e1c852450a53faeed41cf1a Normal file
View File

@ -0,0 +1,73 @@
{
"comments": [
{
"key": {
"uuid": "fa31d9ce_baaff292",
"filename": "fuel_ccp_entrypoint/start_script.py",
"patchSetId": 12
},
"lineNbr": 182,
"author": {
"id": 18652
},
"writtenOn": "2017-02-13T14:24:20Z",
"side": 1,
"message": "we want to get rid of this option, right?..",
"range": {
"startLine": 181,
"startChar": 2,
"endLine": 182,
"endChar": 44
},
"revId": "8263d9303c1ea47c7e1c852450a53faeed41cf1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa31d9ce_ba861211",
"filename": "fuel_ccp_entrypoint/start_script.py",
"patchSetId": 12
},
"lineNbr": 220,
"author": {
"id": 18652
},
"writtenOn": "2017-02-13T14:24:20Z",
"side": 1,
"message": "should be in else:",
"range": {
"startLine": 220,
"startChar": 4,
"endLine": 220,
"endChar": 19
},
"revId": "8263d9303c1ea47c7e1c852450a53faeed41cf1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa31d9ce_3a73024f",
"filename": "fuel_ccp_entrypoint/start_script.py",
"patchSetId": 12
},
"lineNbr": 224,
"author": {
"id": 18652
},
"writtenOn": "2017-02-13T14:24:20Z",
"side": 1,
"message": "move it top and assigne it to var",
"range": {
"startLine": 224,
"startChar": 9,
"endLine": 224,
"endChar": 30
},
"revId": "8263d9303c1ea47c7e1c852450a53faeed41cf1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}