Update patch set 1

Patch Set 1: Code-Review-1 (8 comments) Patch-set: 1 Label: Code-Review=-1
2017-03-02 09:47:47 +00:00 · 2017-03-02 09:47:47 +00:00 · d292b264c7
parent 0e5f8418e7
commit d292b264c7
1 changed files with 164 additions and 0 deletions
--- a/164
+++ b/164
@ -0,0 +1,164 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "ba2be162_60c5d659",
+        "filename": "docker/mysql-client/Dockerfile.j2",
+        "patchSetId": 1
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 18652
+      },
+      "writtenOn": "2017-03-02T09:47:47Z",
+      "side": 1,
+      "message": "Why do we need it at all, if we already have a \"percona\" container?",
+      "revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba2be162_601796ed",
+        "filename": "docker/mysql-client/Dockerfile.j2",
+        "patchSetId": 1
+      },
+      "lineNbr": 5,
+      "author": {
+        "id": 18652
+      },
+      "writtenOn": "2017-03-02T09:47:47Z",
+      "side": 1,
+      "message": "why?",
+      "range": {
+        "startLine": 5,
+        "startChar": 26,
+        "endLine": 5,
+        "endChar": 37
+      },
+      "revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba2be162_2092fe57",
+        "filename": "service/actions/backup-db.yaml",
+        "patchSetId": 1
+      },
+      "lineNbr": 9,
+      "author": {
+        "id": 18652
+      },
+      "writtenOn": "2017-03-02T09:47:47Z",
+      "side": 1,
+      "message": "/opt/ccp/bin",
+      "range": {
+        "startLine": 9,
+        "startChar": 13,
+        "endLine": 9,
+        "endChar": 21
+      },
+      "revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba2be162_40a1b2a2",
+        "filename": "service/actions/backup-db.yaml",
+        "patchSetId": 1
+      },
+      "lineNbr": 11,
+      "author": {
+        "id": 18652
+      },
+      "writtenOn": "2017-03-02T09:47:47Z",
+      "side": 1,
+      "message": "ditto",
+      "range": {
+        "startLine": 11,
+        "startChar": 14,
+        "endLine": 11,
+        "endChar": 22
+      },
+      "revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba2be162_c0368251",
+        "filename": "service/files/backup-db.sh.j2",
+        "patchSetId": 1
+      },
+      "lineNbr": 2,
+      "author": {
+        "id": 18652
+      },
+      "writtenOn": "2017-03-02T09:47:47Z",
+      "side": 1,
+      "message": "this is ok, yet plain text dump is very slow to do and very very slow to load. We need an xtrabackup solution too",
+      "revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba2be162_e09d465a",
+        "filename": "service/files/backup-db.sh.j2",
+        "patchSetId": 1
+      },
+      "lineNbr": 6,
+      "author": {
+        "id": 18652
+      },
+      "writtenOn": "2017-03-02T09:47:47Z",
+      "side": 1,
+      "message": "add \"-\" here",
+      "revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba2be162_60aa3672",
+        "filename": "service/files/backup-db.sh.j2",
+        "patchSetId": 1
+      },
+      "lineNbr": 6,
+      "author": {
+        "id": 18652
+      },
+      "writtenOn": "2017-03-02T09:47:47Z",
+      "side": 1,
+      "message": "not sure if you need seconds",
+      "range": {
+        "startLine": 6,
+        "startChar": 66,
+        "endLine": 6,
+        "endChar": 68
+      },
+      "revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "ba2be162_8013aab7",
+        "filename": "service/files/backup-db.sh.j2",
+        "patchSetId": 1
+      },
+      "lineNbr": 12,
+      "author": {
+        "id": 18652
+      },
+      "writtenOn": "2017-03-02T09:47:47Z",
+      "side": 1,
+      "message": "\"--routines  --triggers\"",
+      "revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}