Update patch set 2
Patch Set 2: (10 comments) sorry, I'm a bit out of time with my comments but anyway Patch-set: 2 Reviewer: Gerrit User 13082 <13082@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
This commit is contained in:
Gerrit User 13082
Gerrit Code Review
parent
cd9732abed
commit
7c9b3f76e7
|
|
@ -0,0 +1,216 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5aef4532_49f5d4c9",
|
||||
"filename": "doc/user/index.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 11,
|
||||
"author": {
|
||||
"id": 13082
|
||||
},
|
||||
"writtenOn": "2016-03-11T10:18:21Z",
|
||||
"side": 1,
|
||||
"message": "please rework this section, with putting it into the separate rst file.\nit should not only provide the list of use case, requirements, limitations and prerequisites, but also explain complex terminology. Please, consider providing deabbreviating some of these terms - people can be totally our of context.",
|
||||
"revId": "05c5cf6d24f223d4f51cbbde1f4fa3935172d777",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5aef4532_862b4b94",
|
||||
"filename": "doc/user/source/build.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 1,
|
||||
"author": {
|
||||
"id": 13082
|
||||
},
|
||||
"writtenOn": "2016-03-11T10:18:21Z",
|
||||
"side": 1,
|
||||
"message": "please remove this whole section because user is supposed to get the plugin from the catalog as RPM i.e. there\u0027s no need to build it by your own means.",
|
||||
"range": {
|
||||
"startLine": 1,
|
||||
"startChar": 6,
|
||||
"endLine": 1,
|
||||
"endChar": 7
|
||||
},
|
||||
"revId": "05c5cf6d24f223d4f51cbbde1f4fa3935172d777",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5aef4532_093f4cd7",
|
||||
"filename": "doc/user/source/configuration.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 37,
|
||||
"author": {
|
||||
"id": 13082
|
||||
},
|
||||
"writtenOn": "2016-03-11T10:18:21Z",
|
||||
"side": 1,
|
||||
"message": "I see brand no information on how to troubleshoot this plugin/where the logs are kept. It would be good to see references to the official Bigswitch documentation for usage-related instructions. Would you please rework the config.files as well as I cannot build up PDF with running make pdf/make latexpdf commands?",
|
||||
"range": {
|
||||
"startLine": 37,
|
||||
"startChar": 3,
|
||||
"endLine": 37,
|
||||
"endChar": 12
|
||||
},
|
||||
"revId": "05c5cf6d24f223d4f51cbbde1f4fa3935172d777",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5aef4532_291fa85c",
|
||||
"filename": "doc/user/source/installation.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 4,
|
||||
"author": {
|
||||
"id": 13082
|
||||
},
|
||||
"writtenOn": "2016-03-11T10:18:21Z",
|
||||
"side": 1,
|
||||
"message": "from the Fuel Plugin Catalog (please add the direct URL to the catalog as well)",
|
||||
"range": {
|
||||
"startLine": 4,
|
||||
"startChar": 12,
|
||||
"endLine": 4,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "05c5cf6d24f223d4f51cbbde1f4fa3935172d777",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5aef4532_490f942e",
|
||||
"filename": "doc/user/source/installation.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 5,
|
||||
"author": {
|
||||
"id": 13082
|
||||
},
|
||||
"writtenOn": "2016-03-11T10:18:21Z",
|
||||
"side": 1,
|
||||
"message": "prior to installation, I would like to see the list of Requirements for this plugin (\u003dwhich MOS version it\u0027s compatible with, which SDN version it works is...). all information on these aspects should be put into the table.\nI also wonder what the prerequisites are: do I need to pre-install any components?",
|
||||
"revId": "05c5cf6d24f223d4f51cbbde1f4fa3935172d777",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5aef4532_095bcc2f",
|
||||
"filename": "doc/user/source/installation.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 6,
|
||||
"author": {
|
||||
"id": 13082
|
||||
},
|
||||
"writtenOn": "2016-03-11T10:18:21Z",
|
||||
"side": 1,
|
||||
"message": "please, provide a link to the corresponding section from the official MOS documentation",
|
||||
"range": {
|
||||
"startLine": 6,
|
||||
"startChar": 10,
|
||||
"endLine": 6,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "05c5cf6d24f223d4f51cbbde1f4fa3935172d777",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5aef4532_296de8cc",
|
||||
"filename": "doc/user/source/installation.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 8,
|
||||
"author": {
|
||||
"id": 13082
|
||||
},
|
||||
"writtenOn": "2016-03-11T10:18:21Z",
|
||||
"side": 1,
|
||||
"message": "Fuel CLI (here you can also refer to the official MOS documentation; User Guide features a set of instructions on what Fuel CLI is)",
|
||||
"range": {
|
||||
"startLine": 8,
|
||||
"startChar": 15,
|
||||
"endLine": 8,
|
||||
"endChar": 21
|
||||
},
|
||||
"revId": "05c5cf6d24f223d4f51cbbde1f4fa3935172d777",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5aef4532_a98f3874",
|
||||
"filename": "doc/user/source/release-notes.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 6,
|
||||
"author": {
|
||||
"id": 13082
|
||||
},
|
||||
"writtenOn": "2016-03-11T10:18:21Z",
|
||||
"side": 1,
|
||||
"message": "these RN are more a mixture of requiremenrs\u0026limitations. could you please put all items listed here into the corresponding sections and put RN section right after you nice overview of the plugin? I\u0027d also write there that this is initial release of the plugin - that\u0027s it.",
|
||||
"revId": "05c5cf6d24f223d4f51cbbde1f4fa3935172d777",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5aef4532_a9e61842",
|
||||
"filename": "specs/index.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 6,
|
||||
"author": {
|
||||
"id": 13082
|
||||
},
|
||||
"writtenOn": "2016-03-11T10:18:21Z",
|
||||
"side": 1,
|
||||
"message": "i",
|
||||
"range": {
|
||||
"startLine": 6,
|
||||
"startChar": 8,
|
||||
"endLine": 6,
|
||||
"endChar": 10
|
||||
},
|
||||
"revId": "05c5cf6d24f223d4f51cbbde1f4fa3935172d777",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5aef4532_9c1c3c6c",
|
||||
"filename": "specs/plugin-1.0.0spec.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 230,
|
||||
"author": {
|
||||
"id": 13082
|
||||
},
|
||||
"writtenOn": "2016-03-11T10:18:21Z",
|
||||
"side": 1,
|
||||
"message": "do you plan to build up CI for the plugin? or using Tempest suite?",
|
||||
"range": {
|
||||
"startLine": 230,
|
||||
"startChar": 15,
|
||||
"endLine": 230,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "05c5cf6d24f223d4f51cbbde1f4fa3935172d777",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue